Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574585

Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

Show all headers | View raw

On Mon, Feb 06, 2017 at 12:19:40PM +0100, Richard Leitner wrote:
> On 02/05/2017 08:42 AM, Greg KH wrote:
> > On Fri, Feb 03, 2017 at 11:55:24AM +0100, Richard Leitner wrote:
> >> +/**
> >> + * ascii2utf16le() - Helper routine for producing UTF-16LE string descriptors
> >> + * @s: Null-terminated ASCII (actually ISO-8859-1) string
> >> + * @buf: Buffer for UTF-16LE string
> >> + * @len: Length (in bytes; may be odd) of UTF-16LE buffer.
> >> + *
> >> + * Return: The number of bytes filled in: 2*strlen(s) or @len, whichever is less
> >> + *
> >> + * Note:
> >> + * The UTF-16LE USB String descriptors can contain at most 31 characters (as
> >> + * specified in the datasheet); input strings longer than that are truncated.
> >> + *
> >> + * Based on ascii2desc from drivers/usb/core/hcd.c
> >> + */
> > 
> > Don't we have a kernel function for this already?  If we need to export
> > ascii2desc() from the USB core, we can do that, or better yet, move both
> > of them to a string library function in the core part of the kernel.  We
> > shouldn't have to duplicate this type of thin in an individual driver.
> 
> Ok. So I'll move the ascii2utf16le function to lib/string.c (?) and call
> it from ascii2desc in drivers/usb/core/hcd.c (due to the fact ascii2desc
> also prepends 2 bytes) and the USB251xB driver? Would that be OK?

That sounds good to me.

> >> --- /dev/null
> >> +++ b/include/linux/platform_data/usb251xb.h
> >> @@ -0,0 +1,33 @@
> > 
> > Do you need a platform data structure here?  Shouldn't we be only using
> > DT now?
> 
> I don't need the platform data support at all. I just added it because
> it is also available in the USB3503 driver. So if it's OK for you I'd be
> glad to remove it.

Great, please remove it! :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver Richard Leitner <richard.leitner@skidata.com> - 2017-02-03 12:00 +0100
  Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Greg KH <gregkh@linuxfoundation.org> - 2017-02-05 08:50 +0100
    Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Richard Leitner <richard.leitner@skidata.com> - 2017-02-06 12:40 +0100
      Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Greg KH <gregkh@linuxfoundation.org> - 2017-02-06 13:00 +0100

csiph-web