Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574343

Re: [PATCH] pinctrl: sunxi: make sun5i explicitly non-modular

Show all headers | View raw

On Fri, Feb 3, 2017 at 4:17 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> We had all these corrected in commit 0c8c6ba00cbf ("pinctrl: sunxi:
> make bool drivers explicitly non-modular") but this new one recently
> crept in.
>
> The Kconfig currently controlling compilation of this code is:
>
>    drivers/pinctrl/sunxi/Kconfig:config PINCTRL_SUN5I
>    drivers/pinctrl/sunxi/Kconfig:  def_bool MACH_SUN5I
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: sunxi: make sun5i explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-02-02 21:20 +0100
  Re: [PATCH] pinctrl: sunxi: make sun5i explicitly non-modular Chen-Yu Tsai <wens@csie.org> - 2017-02-06 04:30 +0100
  Re: [PATCH] pinctrl: sunxi: make sun5i explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2017-02-06 11:30 +0100

csiph-web