Re: [PATCH 2/4] selftests, x86, protection_keys: remove dead code

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] selftests, x86, protection_keys: remove dead code
Date	2017-02-03 00:40 +0100
Message-ID	<t6z8S-29H-17@gated-at.bofh.it> (permalink)
References	<t6yZb-261-7@gated-at.bofh.it> <t6yZc-261-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/02/2017 04:28 PM, Dave Hansen wrote:
> From: Shuah Khan <shuahkh@osg.samsung.com>
> 
> Remove commented out calls to pkey_get().
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

Hi Dave,

This patches is already in linux-kselftest next for 4.11

Is there a reason why you chose to resend these.

-- Shuah

> ---
> 
>  b/tools/testing/selftests/x86/protection_keys.c |   10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff -puN tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-remove-dead-code tools/testing/selftests/x86/protection_keys.c
> --- a/tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-remove-dead-code	2017-02-02 15:27:13.329130196 -0800
> +++ b/tools/testing/selftests/x86/protection_keys.c	2017-02-02 15:27:13.333130376 -0800
> @@ -1114,11 +1114,6 @@ void test_pkey_syscalls_on_non_allocated
>  		err = sys_pkey_free(i);
>  		pkey_assert(err);
>  
> -		/* not enforced when pkey_get() is not a syscall
> -		err = pkey_get(i, 0);
> -		pkey_assert(err < 0);
> -		*/
> -
>  		err = sys_pkey_free(i);
>  		pkey_assert(err);
>  
> @@ -1133,11 +1128,6 @@ void test_pkey_syscalls_bad_args(int *pt
>  	int err;
>  	int bad_pkey = NR_PKEYS+99;
>  
> -	/* not enforced when pkey_get() is not a syscall
> -	err = pkey_get(bad_pkey, bad_flag);
> -	pkey_assert(err < 0);
> -	*/
> -
>  	/* pass a known-invalid pkey in: */
>  	err = sys_mprotect_pkey(ptr, PAGE_SIZE, PROT_READ, bad_pkey);
>  	pkey_assert(err);
> _
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] selftests, x86: updates for x86 protection keys self tests Dave Hansen <dave.hansen@linux.intel.com> - 2017-02-03 00:30 +0100
  [PATCH 4/4] selftests, x86, protection_keys: fix wrong offset in siginfo Dave Hansen <dave.hansen@linux.intel.com> - 2017-02-03 00:30 +0100
  [PATCH 2/4] selftests, x86, protection_keys: remove dead code Dave Hansen <dave.hansen@linux.intel.com> - 2017-02-03 00:30 +0100
    Re: [PATCH 2/4] selftests, x86, protection_keys: remove dead code Shuah Khan <shuahkh@osg.samsung.com> - 2017-02-03 00:40 +0100

csiph-web