Re: [dm-devel] linux-next: Tree for Feb 2 (drivers/md/dm.c)

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [dm-devel] linux-next: Tree for Feb 2 (drivers/md/dm.c)
Date	2017-02-02 21:30 +0100
Message-ID	<t6wb0-hZ-9@gated-at.bofh.it> (permalink)
References	<t6k09-LQ-7@gated-at.bofh.it> <t6tPQ-77C-37@gated-at.bofh.it> <t6uiR-7xo-13@gated-at.bofh.it> <t6uCe-7FA-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/02/2017 10:44, Christoph Hellwig wrote:
> ec8013bedd ("dm: do not forward ioctls from logical volumes to the
> underlying device"),
> 
> The trivial fix would be to add a select of the SCSI_REQUEST symbol
> to dm, but my gut feeling teels me the call is simply wrong, and
> should be removed and instead all ioctls on DM devices that don't
> map to a full underlying devices should be rejected.

I would certainly be fine with that.  It would not be surprising if
something broke, but a middle ground could be to allow all ioctls if you
have CAP_SYS_RAWIO and none if you don't.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: Tree for Feb 2 Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-02 08:30 +0100
  Re: linux-next: Tree for Feb 2 (drivers/md/dm.c) Randy Dunlap <rdunlap@infradead.org> - 2017-02-02 19:00 +0100
    Re: linux-next: Tree for Feb 2 (drivers/md/dm.c) Mike Snitzer <snitzer@redhat.com> - 2017-02-02 19:30 +0100
      Re: [dm-devel] linux-next: Tree for Feb 2 (drivers/md/dm.c) Christoph Hellwig <hch@infradead.org> - 2017-02-02 19:50 +0100
        Re: [dm-devel] linux-next: Tree for Feb 2 (drivers/md/dm.c) Paolo Bonzini <pbonzini@redhat.com> - 2017-02-02 21:30 +0100

csiph-web