Re: [PATCH v3 2/3] crypto: brcm: Add Broadcom SPU driver

From	Rob Rice <rob.rice@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/3] crypto: brcm: Add Broadcom SPU driver
Date	2017-02-02 16:20 +0100
Message-ID	<t6rl0-5HE-25@gated-at.bofh.it> (permalink)
References	<t3yVH-4ad-7@gated-at.bofh.it> <t3yVH-4ad-5@gated-at.bofh.it> <t6qff-54C-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Herbert,


> On Feb 2, 2017, at 9:05 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> 
> On Wed, Jan 25, 2017 at 11:44:48AM -0500, Rob Rice wrote:
>> 
>> +static int ahash_export(struct ahash_request *req, void *out)
>> +{
>> +	const struct iproc_reqctx_s *rctx = ahash_request_ctx(req);
>> +
>> +	memcpy(out, rctx, offsetof(struct iproc_reqctx_s, msg_buf));
>> +	return 0;
>> +}
> 
> The reqctx data structure seems to contain a lot of info unrelated
> to the hash state.  Can't we get away with just copying the hash
> state (incr_hash) itself?

Yes, I see your point. I’ll whittle the export state down to just what’s needed for the hash.

> 
> Cheers,
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/3] crypto: brcm: Add Broadcom SPU driver Herbert Xu <herbert@gondor.apana.org.au> - 2017-02-02 15:10 +0100
  Re: [PATCH v3 2/3] crypto: brcm: Add Broadcom SPU driver Rob Rice <rob.rice@broadcom.com> - 2017-02-02 16:20 +0100

csiph-web