Re: [PATCH v3] netfilter: nf_ct_helper: warn when not applying default helper assignment

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] netfilter: nf_ct_helper: warn when not applying default helper assignment
Date	2017-02-02 14:30 +0100
Message-ID	<t6pCy-4Bc-35@gated-at.bofh.it> (permalink)
References	(5 earlier) <t3BgS-5NU-5@gated-at.bofh.it> <t3CFY-6Do-5@gated-at.bofh.it> <t65Xc-8e7-5@gated-at.bofh.it> <t694K-1Kd-9@gated-at.bofh.it> <t69o5-26I-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 01, 2017 at 09:01:54PM +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> Commit 3bb398d925 ("netfilter: nf_ct_helper: disable automatic helper 
> assignment") is causing behavior regressions in firewalls, as traffic 
> handled by conntrack helpers is now by default not passed through even 
> though it was before due to missing CT targets (which were not necessary 
> before this commit).
> 
> The default had to be switched off due to security reasons [1] [2] and 
> therefore should stay the way it is, but let's be friendly to firewall 
> admins and issue a warning the first time we're in situation where packet 
> would be likely passed through with the old default but we're likely going 
> to drop it on the floor now.
> 
> Rewrite the code a little bit as suggested by Linus, so that we avoid 
> spaghettiing the code even more -- namely the whole decision making 
> process regarding helper selection (either automatic or not) is being 
> separated, so that the whole logic can be simplified and code (condition) 
> duplication reduced.
> 
> [1] https://cansecwest.com/csw12/conntrack-attack.pdf
> [2] https://home.regit.org/netfilter-en/secure-use-of-helpers/

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] netfilter: nf_ct_helper: warn when not applying  default helper assignment Pablo Neira Ayuso <pablo@netfilter.org> - 2017-02-01 17:30 +0100
  Re: [PATCH v2] netfilter: nf_ct_helper: warn when not applying  default helper assignment Jiri Kosina <jikos@kernel.org> - 2017-02-01 20:50 +0100
    [PATCH v3] netfilter: nf_ct_helper: warn when not applying default  helper assignment Jiri Kosina <jikos@kernel.org> - 2017-02-01 21:10 +0100
      Re: [PATCH v3] netfilter: nf_ct_helper: warn when not applying  default helper assignment Pablo Neira Ayuso <pablo@netfilter.org> - 2017-02-02 14:30 +0100

csiph-web