Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1572236
| From | Johannes Stezenbach <js@sig21.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Cherryview wake up events |
| Date | 2017-02-02 11:00 +0100 |
| Message-ID | <t6mlk-2a2-11@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <t4eLf-4FD-9@gated-at.bofh.it> <t4eUX-4Ja-41@gated-at.bofh.it> <t5rdo-bx-7@gated-at.bofh.it> <t5sj8-12l-21@gated-at.bofh.it> <t5HUR-1S1-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Mika,
On Tue, Jan 31, 2017 at 03:37:40PM +0100, Johannes Stezenbach wrote:
> - Powerbutton driver seems simple enough, the only specialty
> of the TI dcove PB driver is the workarond for lost button
> press event after resume. However, I still don't see how
> the PB would cause thermal event irqs on E200HA and how the
> PMIC driver would change it?
In ProductionKernelQuilts I found
DC-TI-PMIC-disable-power-button-support.patch so I guess it
might not be needed because it's probably handled by ACPI.
> I think the mfd driver would be similar to intel_soc_pmic_crc.c,
> the dollar_cove_ti_powerbtn.c I would keep instead of merging
> it into intel_mid_powerbtn.c. I guess what we need is in
> drivers/acpi/pmic/ something similar to intel_pmic_crc.c,
> the ProductionKernelQuilts has 0001-ACPI-Adding-support-for-TI-pmic-opregion.patch.
I have preliminary versions of the mfd and opregion driver,
while testing I found the GPIO opregion is not registered:
Excerpt from DSDT:
https://linuxtv.org/~js/e200ha/dsdt.dsl
Device (PMI2)
{
Name (_ADR, Zero) // _ADR: Address
Name (_HID, "INT33F5" /* TI PMIC Controller */) // _HID: Hardware ID
Name (_CID, "INT33F5" /* TI PMIC Controller */) // _CID: Compatible ID
Name (_DDN, "TI PMIC Controller") // _DDN: DOS Device Name
Name (_HRV, 0x03) // _HRV: Hardware Revision
Name (_UID, One) // _UID: Unique ID
Name (_DEP, Package (0x02) // _DEP: Dependencies
{
I2C7,
GPO1
})
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (SBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x005E, ControllerInitiated, 0x000F4240,
AddressingMode7Bit, "\\_SB.PCI0.I2C7",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Level, ActiveHigh, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x000F
}
})
Return (SBUF) /* \_SB_.PCI0.I2C7.PMI2._CRS.SBUF */
}
...
Name (AVBL, Zero)
Name (AVBD, Zero)
Name (AVBG, Zero)
Method (_REG, 2, NotSerialized) // _REG: Region Availability
{
If (Arg0 == 0x08)
{
AVBG = Arg1
}
If (Arg0 == 0x8D)
{
AVBL = Arg1
}
If (Arg0 == 0x8C)
{
AVBD = Arg1
}
}
acpidbg:
\_SB.PCI0.I2C7.PMI2.AVBL Integer ffff8be7b74d97a8 01 = 0000000000000001
\_SB.PCI0.I2C7.PMI2.AVBD Integer ffff8be7b74d94d8 01 = 0000000000000001
\_SB.PCI0.I2C7.PMI2.AVBG Integer ffff8be7b74d9be0 01 = 0000000000000000
Any idea about it?
devm_gpiochip_add_data() in chv_gpio_probe() indirectly calls acpi_gpiochip_add()
which should use _DEP to figure out to call _REG, right?
Also PMI2 has
OperationRegion (GPOP, GeneralPurposeIo, Zero, 0x0100)
Field (GPOP, ByteAcc, NoLock, Preserve)
{
Connection (
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly,
"\\_SB.PCI0.I2C7.PMI2", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0020
}
),
GMP0, 1,
...
(repeat for many more pins)
I guess it means it uses chv_gpio pins and can't work
if the GPIO opregion is not registered?
FWIW, with the mfd driver, /proc/interrupts has
180: 0 0 0 0 chv-gpio 9 TI Dollar Cove
I guess the 9 refers to the 10th pin in north_pins[] which is pin 0x000F, right?
I boot with "dyndbg=file gpiolib* +p" and get
[ +0.012798] acpi INT33F5:00: GPIO: looking up 0 in _CRS
[ +0.000214] intel_soc_pmic_i2c i2c-INT33F5:00: GPIO lookup for consumer intel_soc_pmic
[ +0.000003] intel_soc_pmic_i2c i2c-INT33F5:00: using ACPI for GPIO lookup
[ +0.000005] acpi INT33F5:00: GPIO: looking up intel_soc_pmic-gpios
[ +0.000005] acpi INT33F5:00: GPIO: looking up intel_soc_pmic-gpio
[ +0.000005] acpi INT33F5:00: GPIO: looking up 0 in _CRS
[ +0.000091] cherryview-pinctrl INT33FF:01: request pin 15 (GPIO_SUS0) for INT33FF:01:406
but so far the irq never triggers.
Thanks
Johannes
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-01-30 22:00 +0100
Re: Cherryview wake up events Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-30 23:10 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-01-31 15:50 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-01-31 15:50 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-02 11:00 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-02 11:40 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-02 12:20 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-02 12:40 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-02 13:20 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-02 15:00 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-02 15:30 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-02 15:40 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-02 16:10 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-02 16:50 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-02 17:00 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-02 18:40 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-03 11:10 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-03 14:20 +0100
Re: Cherryview wake up events Johannes Stezenbach <js@sig21.net> - 2017-02-09 10:30 +0100
Re: Cherryview wake up events Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-09 10:50 +0100
csiph-web