Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572182

Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT()

Show all headers | View raw

On Feb 1, 2017, at 09:52, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> lustre uses a fake switch() statement as a compile-time assert, but unfortunately
> each use of that causes a warning when building with clang:
> 
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2907:2: warning: no case matching constant switch condition '42'
> drivers/staging/lustre/lnet/klnds/socklnd/../../../include/linux/libcfs/libcfs_private.h:294:36: note: expanded from macro 'CLASSERT'
> #define CLASSERT(cond) do {switch (42) {case (cond): case 0: break; } } while (0)
> 
> Adding a 'default:' label in there shuts up the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>

> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
> index aab15d8112a4..2d5435029185 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
> @@ -291,7 +291,7 @@ do {							    \
>  *       value  after  conversion...
>  *
>  */
> -#define CLASSERT(cond) do {switch (42) {case (cond): case 0: break; } } while (0)
> +#define CLASSERT(cond) do {switch (42) {case (cond): case 0: default: break; } } while (0)
> 
> /* max value for numeric network address */
> #define MAX_NUMERIC_VALUE 0xffffffff
> -- 
> 2.9.0
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: shut up clang warnings on CLASSERT() Arnd Bergmann <arnd@arndb.de> - 2017-02-01 18:00 +0100
  Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT() "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-02-02 09:00 +0100
    Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-02 11:00 +0100
      Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT() Arnd Bergmann <arnd@arndb.de> - 2017-02-02 11:50 +0100
        Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-02 11:50 +0100
          Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT() Arnd Bergmann <arnd@arndb.de> - 2017-02-02 12:30 +0100

csiph-web