Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572154

Re: [PATCH 3/6] async_tx: Handle DMA devices having support for fewer PQ coefficients

Show all headers | View raw

On Wed, Feb 1, 2017 at 8:47 PM, Anup Patel <anup.patel@broadcom.com> wrote:
> The DMAENGINE framework assumes that if PQ offload is supported by a
> DMA device then all 256 PQ coefficients are supported. This assumption
> does not hold anymore because we now have BCM-SBA-RAID offload engine
> which supports PQ offload with limited number of PQ coefficients.
>
> This patch extends async_tx APIs to handle DMA devices with support
> for fewer PQ coefficients.
>
> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  crypto/async_tx/async_pq.c          |  3 +++
>  crypto/async_tx/async_raid6_recov.c | 12 ++++++++++--
>  include/linux/dmaengine.h           | 19 +++++++++++++++++++
>  include/linux/raid/pq.h             |  3 +++
>  4 files changed, 35 insertions(+), 2 deletions(-)

So, I hate the way async_tx does these checks on each operation, and
it's ok for me to say that because it's my fault. Really it's md that
should be validating engine offload capabilities once at the beginning
of time. I'd rather we move in that direction than continue to pile
onto a bad design.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Broadcom SBA RAID support Anup Patel <anup.patel@broadcom.com> - 2017-02-02 05:50 +0100
  [PATCH 3/6] async_tx: Handle DMA devices having support for fewer PQ coefficients Anup Patel <anup.patel@broadcom.com> - 2017-02-02 05:50 +0100
    Re: [PATCH 3/6] async_tx: Handle DMA devices having support for fewer  PQ coefficients Dan Williams <dan.j.williams@intel.com> - 2017-02-02 07:10 +0100
      Re: [PATCH 3/6] async_tx: Handle DMA devices having support for fewer  PQ coefficients Anup Patel <anup.patel@broadcom.com> - 2017-02-03 12:10 +0100
      Re: [PATCH 3/6] async_tx: Handle DMA devices having support for fewer  PQ coefficients Dan Williams <dan.j.williams@intel.com> - 2017-02-03 19:50 +0100
        Re: [PATCH 3/6] async_tx: Handle DMA devices having support for fewer  PQ coefficients Anup Patel <anup.patel@broadcom.com> - 2017-02-06 05:00 +0100
  [PATCH 1/6] mailbox: Add new API mbox_channel_device() for clients Anup Patel <anup.patel@broadcom.com> - 2017-02-02 05:50 +0100
    Re: [PATCH 1/6] mailbox: Add new API mbox_channel_device() for clients Jassi Brar <jassisinghbrar@gmail.com> - 2017-02-03 13:10 +0100
      Re: [PATCH 1/6] mailbox: Add new API mbox_channel_device() for clients Anup Patel <anup.patel@broadcom.com> - 2017-02-06 05:30 +0100
  [PATCH 4/6] async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() Anup Patel <anup.patel@broadcom.com> - 2017-02-02 05:50 +0100
  [PATCH 6/6] dt-bindings: Add DT bindings document for Broadcom SBA RAID driver Anup Patel <anup.patel@broadcom.com> - 2017-02-02 05:50 +0100
  Re: [PATCH 5/6] dmaengine: Add Broadcom SBA RAID driver Vinod Koul <vinod.koul@intel.com> - 2017-02-05 07:10 +0100
    Re: [PATCH 5/6] dmaengine: Add Broadcom SBA RAID driver Anup Patel <anup.patel@broadcom.com> - 2017-02-06 13:10 +0100
      Re: [PATCH 5/6] dmaengine: Add Broadcom SBA RAID driver Vinod Koul <vinod.koul@intel.com> - 2017-02-06 18:00 +0100
        Re: [PATCH 5/6] dmaengine: Add Broadcom SBA RAID driver Anup Patel <anup.patel@broadcom.com> - 2017-02-07 07:10 +0100

csiph-web