Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1572147
| From | Eduardo Valentin <edubezval@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 3/3] thermal: zx2967: add thermal driver for ZTE's zx2967 family |
| Date | 2017-02-02 06:10 +0100 |
| Message-ID | <t6hOF-7HV-5@gated-at.bofh.it> (permalink) |
| References | <t0Qm5-7Ro-3@gated-at.bofh.it> <t0Qm5-7Ro-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hey Bao, On Wed, Jan 18, 2017 at 12:42:02PM +0800, Baoyou Xie wrote: > This patch adds thermal driver for ZTE's zx2967 family. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> <cut> > + > + /* > + * Calculate temperature > + * 922 initial value of calibration cure > + * 1.951 slope of calibration cure > + */ > + *temp = DIV_ROUND_CLOSEST((val - 922) * 1000, 1951); You can describe the offset and slope using DT and avoid this to be hard coded in your driver. Besides, if you read offset and slope from DT, your driver will be ready for any upcoming sensor addition that you may want to support in future, given that would required slope and offset change, per sensor, per chip version. Can you please check if you can move these to DT? BR, > -- > 2.7.4 >
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v5 3/3] thermal: zx2967: add thermal driver for ZTE's zx2967 family Eduardo Valentin <edubezval@gmail.com> - 2017-02-02 06:10 +0100
csiph-web