Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572126

[PATCH] drm: change connector disconnected debug message to an error

Show all headers | View raw

Change drm_helper_probe_single_connector_modes() to print an error to
report connector disconnected status instead of a debug message.

When this condition occurs, application doesn't know the real error and
reports it as driver lacking support for mode setting. Change it to an
error to make it easier to debug.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 drivers/gpu/drm/drm_probe_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index ac953f0..6472b7f 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -282,8 +282,8 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector,
 	dev->mode_config.poll_running = drm_kms_helper_poll;
 
 	if (connector->status == connector_status_disconnected) {
-		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] disconnected\n",
-			connector->base.id, connector->name);
+		DRM_ERROR("[CONNECTOR:%d:%s] disconnected\n",
+			  connector->base.id, connector->name);
 		drm_mode_connector_update_edid_property(connector, NULL);
 		verbose_prune = false;
 		goto prune;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm: change connector disconnected debug message to an error Shuah Khan <shuahkh@osg.samsung.com> - 2017-02-02 04:00 +0100
  Re: [PATCH] drm: change connector disconnected debug message to an error Jani Nikula <jani.nikula@linux.intel.com> - 2017-02-02 09:40 +0100
    Re: [PATCH] drm: change connector disconnected debug message to an  error Shuah Khan <shuahkh@osg.samsung.com> - 2017-02-02 18:30 +0100
      Re: [PATCH] drm: change connector disconnected debug message to an error Jani Nikula <jani.nikula@linux.intel.com> - 2017-02-03 09:00 +0100
      Re: [PATCH] drm: change connector disconnected debug message to an  error Daniel Vetter <daniel@ffwll.ch> - 2017-02-03 09:10 +0100
        Re: [PATCH] drm: change connector disconnected debug message to an  error Shuah Khan <shuahkh@osg.samsung.com> - 2017-02-10 18:00 +0100

csiph-web