Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572046

Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support

Show all headers | View raw

On Thu, Feb 02, 2017 at 12:16:24PM +1300, Chris Packham wrote:
> The l2-cache controller on the T2080 SoC has similar capabilities to the
> others already supported by the mpc85xx_edac driver. Add it to the list
> of compatible devices.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Acked-by: Johannes Thumshirn <jth@kernel.org>
> ---
> This is a resend of a patch that got an ack[1] but didn't seem to get
> picked up.
> 
> [1] http://marc.info/?l=linux-edac&m=148042072225488&w=2
> 
> Changes since v1:
> - Collect ack from Johannes.

Whoops, my bad. Sorry about that.

>  arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 1 +
>  drivers/edac/mpc85xx_edac.c                 | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> index c744569a20e1..a97296c64eb2 100644
> --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> @@ -678,5 +678,6 @@
>  		compatible = "fsl,t2080-l2-cache-controller";
>  		reg = <0xc20000 0x40000>;
>  		next-level-cache = <&cpc>;
> +		interrupts = <16 2 1 9>;
>  	};
>  };
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 8f66cbed70b7..67f7bc3fe5b3 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -629,6 +629,7 @@ static const struct of_device_id mpc85xx_l2_err_of_match[] = {
>  	{ .compatible = "fsl,p1020-l2-cache-controller", },
>  	{ .compatible = "fsl,p1021-l2-cache-controller", },
>  	{ .compatible = "fsl,p2020-l2-cache-controller", },
> +	{ .compatible = "fsl,t2080-l2-cache-controller", },

WARNING: DT compatible string "fsl,t2080-l2-cache-controller" appears un-documented -- check ./Documentation/devicetree/bindings/
#58: FILE: drivers/edac/mpc85xx_edac.c:632:
+       { .compatible = "fsl,t2080-l2-cache-controller", },

What is checkpatch.pl trying to tell me here?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-02-02 00:20 +0100
  Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Borislav Petkov <bp@alien8.de> - 2017-02-02 00:30 +0100
    Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-02-02 00:50 +0100
      Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Borislav Petkov <bp@alien8.de> - 2017-02-02 18:50 +0100
        Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Michael Ellerman <mpe@ellerman.id.au> - 2017-02-03 01:00 +0100
          Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-02-03 01:20 +0100
            Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Michael Ellerman <mpe@ellerman.id.au> - 2017-02-03 06:20 +0100
          Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support Borislav Petkov <bp@alien8.de> - 2017-02-03 10:50 +0100

csiph-web