Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1573531

[PATCH V2 4/7] mm: enable MADV_FREE for swapless system

From Shaohua Li <shli@fb.com>
Newsgroups linux.kernel
Subject [PATCH V2 4/7] mm: enable MADV_FREE for swapless system
Date 2017-02-04 00:40 +0100
Message-ID <t6VCq-c7-21@gated-at.bofh.it> (permalink)
References <t6VCp-c7-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Now MADV_FREE pages can be easily reclaimed even for swapless system. We
can safely enable MADV_FREE for all systems.

Cc: Michal Hocko <mhocko@suse.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Shaohua Li <shli@fb.com>
---
 mm/madvise.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/mm/madvise.c b/mm/madvise.c
index c24549e..fe40e93 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -579,13 +579,7 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev,
 	case MADV_WILLNEED:
 		return madvise_willneed(vma, prev, start, end);
 	case MADV_FREE:
-		/*
-		 * XXX: In this implementation, MADV_FREE works like
-		 * MADV_DONTNEED on swapless system or full swap.
-		 */
-		if (get_nr_swap_pages() > 0)
-			return madvise_free(vma, prev, start, end);
-		/* passthrough */
+		return madvise_free(vma, prev, start, end);
 	case MADV_DONTNEED:
 		return madvise_dontneed(vma, prev, start, end);
 	default:
-- 
2.9.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 0/7] mm: fix some MADV_FREE issues Shaohua Li <shli@fb.com> - 2017-02-04 00:40 +0100
  [PATCH V2 5/7] mm: add vmstat account for MADV_FREE pages Shaohua Li <shli@fb.com> - 2017-02-04 00:40 +0100
    Re: [PATCH V2 5/7] mm: add vmstat account for MADV_FREE pages Michal Hocko <mhocko@kernel.org> - 2017-02-10 14:30 +0100
  [PATCH V2 4/7] mm: enable MADV_FREE for swapless system Shaohua Li <shli@fb.com> - 2017-02-04 00:40 +0100
  [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Shaohua Li <shli@fb.com> - 2017-02-04 00:40 +0100
    Re: [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Michal Hocko <mhocko@kernel.org> - 2017-02-10 15:10 +0100
  [PATCH V2 3/7] mm: reclaim MADV_FREE pages Shaohua Li <shli@fb.com> - 2017-02-04 00:40 +0100
    Re: [PATCH V2 3/7] mm: reclaim MADV_FREE pages Minchan Kim <minchan@kernel.org> - 2017-02-10 08:00 +0100
      Re: [PATCH V2 3/7] mm: reclaim MADV_FREE pages Minchan Kim <minchan@kernel.org> - 2017-02-13 06:10 +0100
    Re: [PATCH V2 3/7] mm: reclaim MADV_FREE pages Michal Hocko <mhocko@kernel.org> - 2017-02-10 14:30 +0100
  [PATCH V2 1/7] mm: don't assume anonymous pages have SwapBacked flag Shaohua Li <shli@fb.com> - 2017-02-04 00:40 +0100
  [PATCH V2 7/7] mm: add a separate RSS for MADV_FREE pages Shaohua Li <shli@fb.com> - 2017-02-04 00:40 +0100
    Re: [PATCH V2 7/7] mm: add a separate RSS for MADV_FREE pages Michal Hocko <mhocko@kernel.org> - 2017-02-10 14:40 +0100

csiph-web