Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1573488
| From | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family |
| Date | 2017-02-03 23:40 +0100 |
| Message-ID | <t6UGm-809-5@gated-at.bofh.it> (permalink) |
| References | <t6TKi-7ml-17@gated-at.bofh.it> <t6TTX-7qD-15@gated-at.bofh.it> <t6UGm-809-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Feb 3, 2017 at 4:48 PM, Rafał Miłecki <rafal@milecki.pl> wrote: > On 2017-02-03 22:39, Jon Mason wrote: >> >> BCM471X and BCM535X are of the same family (from what I can derive from >> internal documents). Group them into the case statement together, which >> results in more code reuse. >> >> Also, use existing helper variables to make the code a little more >> readable too. >> >> Signed-off-by: Jon Mason <jon.mason@broadcom.com> > > > I'd like to review it / test it on few devices. Please give me weekend for > that. Yes, please test this as much as you can. The code move was pretty innocuous, and those are always the times when it comes back to bite me. Thanks, Jon
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/3] net: ethernet: bgmac: PM support and clean-ups Jon Mason <jon.mason@broadcom.com> - 2017-02-03 22:40 +0100
[PATCH 3/3] net: ethernet: bgmac: driver power manangement Jon Mason <jon.mason@broadcom.com> - 2017-02-03 22:50 +0100
Re: [PATCH 3/3] net: ethernet: bgmac: driver power manangement Florian Fainelli <f.fainelli@gmail.com> - 2017-02-04 03:20 +0100
Re: [PATCH 3/3] net: ethernet: bgmac: driver power manangement Jon Mason <jon.mason@broadcom.com> - 2017-02-06 17:40 +0100
[PATCH 1/3] net: ethernet: bgmac: use #defines for MAX size Jon Mason <jon.mason@broadcom.com> - 2017-02-03 22:50 +0100
[PATCH 2/3] net: ethernet: bgmac: unify code of the same family Jon Mason <jon.mason@broadcom.com> - 2017-02-03 22:50 +0100
Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family Jon Mason <jon.mason@broadcom.com> - 2017-02-03 23:40 +0100
Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family Rafał Miłecki <rafal@milecki.pl> - 2017-02-04 00:10 +0100
csiph-web