Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1573416
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv2 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX |
| Date | 2017-02-03 21:10 +0100 |
| Message-ID | <t6Slb-6x5-9@gated-at.bofh.it> (permalink) |
| References | <t6Qjo-4OT-13@gated-at.bofh.it> <t6Qjo-4OT-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Feb 3, 2017 at 9:52 AM, Laura Abbott <labbott@redhat.com> wrote: > > Both of these options are poorly named. The features they provide are > necessary for system security and should not be considered debug only. > Change the name to something that accurately describes what these > options do. It may help to explicitly call out the name change from/to in the commit message. > > Signed-off-by: Laura Abbott <labbott@redhat.com> > --- > [...] > diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/configs/aspeed_g4_defconfig > index ca39c04..beea2cc 100644 > --- a/arch/arm/configs/aspeed_g4_defconfig > +++ b/arch/arm/configs/aspeed_g4_defconfig > @@ -25,7 +25,6 @@ CONFIG_MODULE_UNLOAD=y > # CONFIG_ARCH_MULTI_V7 is not set > CONFIG_ARCH_ASPEED=y > CONFIG_MACH_ASPEED_G4=y > -CONFIG_DEBUG_RODATA=y > CONFIG_AEABI=y > CONFIG_UACCESS_WITH_MEMCPY=y > CONFIG_SECCOMP=y Are these defconfig cases correct (dropping DEBUG_RODATA without adding STRICT_KERNEL_RWX)? Who should carry this series, btw? -Kees -- Kees Cook Pixel Security
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv2 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX Laura Abbott <labbott@redhat.com> - 2017-02-03 19:00 +0100
Re: [PATCHv2 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX Mark Rutland <mark.rutland@arm.com> - 2017-02-03 19:30 +0100
Re: [PATCHv2 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX Kees Cook <keescook@chromium.org> - 2017-02-03 21:10 +0100
Re: [PATCHv2 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX Laura Abbott <labbott@redhat.com> - 2017-02-06 19:50 +0100
Re: [PATCHv2 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX Kees Cook <keescook@chromium.org> - 2017-02-06 21:20 +0100
csiph-web