Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations
Date	2017-02-03 19:00 +0100
Message-ID	<t6Qjo-4OT-25@gated-at.bofh.it> (permalink)
References	<t6Q9H-4Ln-7@gated-at.bofh.it> <t6Q9I-4Ln-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote:
> The ldmvsw driver is specifically for supporting the ldom virtual
> networking by running in the primary ldom and using the LDC to connect
> the remaining ldoms to the outside world via a bridge.  With TSO and GSO
> supported while connected the bridge, things tend to misbehave as seen in
> our case by delayed packets, enough to begin triggering retransmits and
> affecting overall throughput.  By turning off advertised support for TSO
> and GSO we restore stable traffic flow through the bridge.
> 
> Orabug: 23293104
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
> ---
>  drivers/net/ethernet/sun/ldmvsw.c         |    5 ++---
>  drivers/net/ethernet/sun/sunvnet_common.c |    3 ++-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c
> index 552c0a9..bd2cfbc 100644
> --- a/drivers/net/ethernet/sun/ldmvsw.c
> +++ b/drivers/net/ethernet/sun/ldmvsw.c
> @@ -299,8 +299,7 @@ static struct net_device *vsw_alloc_netdev(u8 hwaddr[],
>  	dev->ethtool_ops = &vsw_ethtool_ops;
>  	dev->watchdog_timeo = VSW_TX_TIMEOUT;
>  
> -	dev->hw_features = NETIF_F_TSO | NETIF_F_GSO | NETIF_F_GSO_SOFTWARE |
> -			   NETIF_F_HW_CSUM | NETIF_F_SG;
> +	dev->hw_features = NETIF_F_HW_CSUM;


You also removed NETIF_F_SG

Thread

[PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-03 18:50 +0100
  Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge  operations Eric Dumazet <eric.dumazet@gmail.com> - 2017-02-03 19:00 +0100
    Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge  operations Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-03 22:30 +0100

csiph-web