Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter

From	Adam Borowski <kilobyte@angband.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter
Date	2017-02-03 17:50 +0100
Message-ID	<t6PdD-4aP-9@gated-at.bofh.it> (permalink)
References	<sY7Mt-3II-11@gated-at.bofh.it> <sYc9r-6qU-3@gated-at.bofh.it> <sYcj7-6ul-9@gated-at.bofh.it> <t6vRE-aV-21@gated-at.bofh.it> <t6OAV-3WY-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 03, 2017 at 05:04:15PM +0100, Manuel Schölling wrote:
> On Thu, 2017-02-02 at 15:07 -0500, Paul Gortmaker wrote:
> > On Tue, Jan 10, 2017 at 4:28 PM, Manuel Schölling
> > <manuel.schoelling@gmx.de> wrote:
> > > The impact of the persistent scrollback feature on the code size is
> > > rather small, so the config option is removed. The feature stays
> > > disabled by default and can be enabled by using the boot command
> > > line
> > > parameter 'vgacon.scrollback_persistent=1' or by setting
> > > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y.
> > 
> > [...]
> > 
> > > +module_param_named(scrollback_persistent, scrollback_persistent,
> > > bool, 0000);
> > > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent
> > > scrollback for all vga consoles");
> > 
> > Since this hasn't got widespread deployment yet and  only exists
> > in Greg's tree, can we please fix the above to use setup_param or
> > similar, since there is nothing modular about this code at all.
> Not sure what you mean here.
> If this is not the right may to declare it I'd be more than happy to
> change this. But I could not find any function/macro named setup_param
> [1].
> It would be great if you could give me a hint what function to use
> here!
> 
> [1] http://lxr.free-electrons.com/ident?i=setup_param

That shows only exact matches.

You want "git grep setup_param", which shows __setup_param() plus some
unrelated stuff.  I see only four uses in the kernel, but that's enough
to see how to use it.


Meow!
-- 
Autotools hint: to do a zx-spectrum build on a pdp11 host, type:
  ./configure --host=zx-spectrum --build=pdp11

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-02-02 21:10 +0100
  Re: [PATCH v9 4/4] console: Make persistent scrollback a boot  parameter Manuel Schölling <manuel.schoelling@gmx.de> - 2017-02-03 17:10 +0100
    Re: [PATCH v9 4/4] console: Make persistent scrollback a boot  parameter Adam Borowski <kilobyte@angband.pl> - 2017-02-03 17:50 +0100

csiph-web