Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573155

Re: [PATCH v5 3/4] device property: export code duplicating array of property entries

Show all headers | View raw

On Fri, Feb 03, 2017 at 01:45:30PM +0200, Andy Shevchenko wrote:
> On Thu, 2017-02-02 at 17:41 -0800, Dmitry Torokhov wrote:
> > When augmenting ACPI-enumerated devices with additional property data
> > based
> > on DMI info, a module has often several potential property sets, with
> > only
> > one being active on a given box. In order to save memory it should be
> > possible to mark everything and __initdata or __initconst, execute DMI
> > match early, and duplicate relevant properties. Then kernel will
> > discard
> > the rest of them.
> > 
> 
> Here you again rewrote the code you rewrote in previous patch.
> Please, remove those hunks in previous patch and rebase this one on top
> of the result.

I do no see the point really. If I am not exposing the new APIs then
there is no point in touching the code. If I am creating new API then I
do not want to go through contortion of producing something similar to
the old code flow just to "fix" it in the subsequent patch.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/4] Export APIs to copy device properties & more Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-03 02:50 +0100
  [PATCH v5 3/4] device property: export code duplicating array of property entries Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-03 02:50 +0100
    Re: [PATCH v5 3/4] device property: export code duplicating array  of property entries Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-03 12:50 +0100
      Re: [PATCH v5 3/4] device property: export code duplicating array of  property entries Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-03 16:20 +0100
  Re: [PATCH v5 0/4] Export APIs to copy device properties & more "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-02-09 15:00 +0100

csiph-web