Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1573141
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 6/7] mm: vmscan: move dirty pages out of the way until they're flushed |
| Date | 2017-02-03 16:20 +0100 |
| Message-ID | <t6NOy-3bO-5@gated-at.bofh.it> (permalink) |
| References | <t6veV-89s-11@gated-at.bofh.it> <t6veW-89s-31@gated-at.bofh.it> <t6GN4-74a-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri 03-02-17 15:42:55, Hillf Danton wrote:
>
> On February 03, 2017 3:20 AM Johannes Weiner wrote:
> > @@ -1063,7 +1063,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> > PageReclaim(page) &&
> > test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
> > nr_immediate++;
> > - goto keep_locked;
> > + goto activate_locked;
>
> Out of topic but relevant IMHO, I can't find where it is cleared by grepping:
>
> $ grep -nr PGDAT_WRITEBACK linux-4.9/mm
> linux-4.9/mm/vmscan.c:1019: test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
> linux-4.9/mm/vmscan.c:1777: set_bit(PGDAT_WRITEBACK, &pgdat->flags);
I would just get rid of this flag.
--
Michal Hocko
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] mm: vmscan: fix kswapd writeback regression v2 Johannes Weiner <hannes@cmpxchg.org> - 2017-02-02 20:30 +0100
[PATCH 7/7] mm: vmscan: move dirty pages out of the way until they're flushed fix Johannes Weiner <hannes@cmpxchg.org> - 2017-02-02 20:30 +0100
[PATCH 4/7] mm: vmscan: remove old flusher wakeup from direct reclaim path Johannes Weiner <hannes@cmpxchg.org> - 2017-02-02 20:30 +0100
[PATCH 6/7] mm: vmscan: move dirty pages out of the way until they're flushed Johannes Weiner <hannes@cmpxchg.org> - 2017-02-02 20:30 +0100
Re: [PATCH 6/7] mm: vmscan: move dirty pages out of the way until they're flushed "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-02-03 08:50 +0100
Re: [PATCH 6/7] mm: vmscan: move dirty pages out of the way until they're flushed Michal Hocko <mhocko@kernel.org> - 2017-02-03 16:20 +0100
Re: [PATCH 0/7] mm: vmscan: fix kswapd writeback regression v2 Andrew Morton <akpm@linux-foundation.org> - 2017-02-02 23:50 +0100
csiph-web