Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1573098
| Path | csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Corentin Labbe <clabbe.montjoie@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX |
| Date | Fri, 03 Feb 2017 14:50:02 +0100 |
| Message-ID | <t6Mps-2cV-29@gated-at.bofh.it> (permalink) |
| References | <t5CLw-7mj-19@gated-at.bofh.it> <t5CLw-7mj-21@gated-at.bofh.it> <t5UyJ-17o-1@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TusTscCMubqUZPoLPG9Yi6F+nQj+mV5FYNKWPRTgpaQ=; b=rnJUuPRJ0ShcbP3yXm1EeLdRMXqz3lVOfjct9hKcR3DvgtuqJzPImuu7/WuPXa2FIv 9EsczqY1CLWUg53Kb0ght0mhBHSoXuxVWL6hpF+QovL8m+kd3a24X3Y31Z9K4yczL005 hz59Gp7Hzf9puFjrHLnTpD6EhaTJdapAlC8qJx/ZByqU3l0BgXhAAb3AHLSFjJVsjtFo mboYxTYt0QsnM1ukF0UwfPatMALCWf15MhO3/EpC9Hxp61EVCnAorctJy9HzOmOhqqIe cxIGcXhALx4nAF07hxPw3bsVh+qEAwlm4SnJEVKkuLvN6+1jiAKF+YVCuKlruw7WWA1n 2ang== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TusTscCMubqUZPoLPG9Yi6F+nQj+mV5FYNKWPRTgpaQ=; b=McYk6zkO1sDLUJyWIxBxsij4NZZOkNDqi/46+wSuCs7W+qBBXh45+dXBvz7A14JoGw 9zAXOhGaA2IY4O11Pg4M8vIsdaTtgpgkK0b+EmsIvbhtLEjuPDuQOmLQRUWmXWJ9BMG4 OD9IN56xiCEOdKUOTeU+7wH2QB/RuCMBgoyQGzwV/q5gibGC6j3BPuxhM8veh2ZDTa+z oxVpUl/LFYfiQU3vXEW3mh6zliaeDEjn0eihG43FMKc4OchGZR9Ii/h2A+7xDdDaeqsf YvTS4LY/GJjsbuD3BBdiquLKfhhaV/TYt4clpZpV70g+oSu2qhx3LhKS797Swy/BFcUV Hfeg== |
| X-Gm-Message-State | AMke39mDrOKRD784nMHdpwfQ/idCg33dXvYxrobyIr6Ox1Tfs2DhdPgD5vTv0cE5H2bNGQ== |
| X-Received | by 10.28.103.3 with SMTP id b3mr1402919wmc.99.1486129308534; Fri, 03 Feb 2017 05:41:48 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 25 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Fri, 3 Feb 2017 14:41:45 +0100 |
| X-Original-Message-ID | <20170203134145.GB3653@Red> |
| X-Original-References | <20170131091152.13842-1-clabbe.montjoie@gmail.com> <20170131091152.13842-14-clabbe.montjoie@gmail.com> <20170131.231225.59679013563845652.davem@davemloft.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1573098 |
Show key headers only | View raw
On Tue, Jan 31, 2017 at 11:12:25PM -0500, David Miller wrote: > From: Corentin Labbe <clabbe.montjoie@gmail.com> > Date: Tue, 31 Jan 2017 10:11:48 +0100 > > > The stmmac driver run TX completion under NAPI but without checking > > the work done by the TX completion function. > > The current behavior is correct and completely intentional. > > A driver should _never_ account TX work to the NAPI poll budget. > > This is because TX liberation is orders of magnitude cheaper than > receiving a packet, and such SKB freeing makes more SKBs available > for RX processing. > > Therefore, TX work should never count against the NAPI budget. > > Please do not fix something which is not broken. So at least the documentation I read must be fixed (https://wiki.linuxfoundation.org/networking/napi) So perhaps the best way is to do like intel igb/ixgbe, keeping under NAPI until the stmmac_tx_clean function said that it finish handling the queue ? Regards Corentin Labbe
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 13/17] net: stmmac: Implement NAPI for TX Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-01-31 10:20 +0100
Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-01-31 11:30 +0100
Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-01-31 14:50 +0100
Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX David Miller <davem@davemloft.net> - 2017-02-01 05:20 +0100
Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-03 14:50 +0100
Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX David Miller <davem@davemloft.net> - 2017-02-03 16:20 +0100
Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-03 17:00 +0100
csiph-web