Re: [PATCH 10/60] staging: lustre: obdclass: add more info to sysfs version string

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/60] staging: lustre: obdclass: add more info to sysfs version string
Date	2017-02-03 11:40 +0100
Message-ID	<t6JrA-o3-29@gated-at.bofh.it> (permalink)
References	<t4Lea-8ik-3@gated-at.bofh.it> <t4LnP-8lZ-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote:
> From: Andreas Dilger <andreas.dilger@intel.com>
> 
> Update the sysfs "version" file to print "lustre: " with
> the version number.
> 
> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5969
> Reviewed-on: http://review.whamcloud.com/16721
> Reviewed-by: James Simmons <uja.ornl@yahoo.com>
> Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
> Signed-off-by: James Simmons <jsimmons@infradead.org>
> ---
>  drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> index 9f5e829..22e6d1f 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> @@ -208,7 +208,7 @@ struct miscdevice obd_psdev = {
>  static ssize_t version_show(struct kobject *kobj, struct attribute *attr,
>  			    char *buf)
>  {
> -	return sprintf(buf, "%s\n", LUSTRE_VERSION_STRING);
> +	return sprintf(buf, "lustre: %s\n", LUSTRE_VERSION_STRING);
>  }

Why?  You "know" this is lustre, why say it again?  Doesn't this affect
userspace tools?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 10/60] staging: lustre: obdclass: add more info to sysfs  version string Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-03 11:40 +0100
  Re: [lustre-devel] [PATCH 10/60] staging: lustre: obdclass: add  more info to sysfs version string "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-02-08 02:10 +0100
    Re: [lustre-devel] [PATCH 10/60] staging: lustre: obdclass: add more  info to sysfs version string Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-08 07:30 +0100

csiph-web