Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

Path	csiph.com!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot
Date	Fri, 03 Feb 2017 11:50:02 +0100
Message-ID	<t6JBf-ru-5@gated-at.bofh.it> (permalink)
References	<swTxv-2VB-3@gated-at.bofh.it> <swTxx-2VB-55@gated-at.bofh.it> <swUad-3cE-1@gated-at.bofh.it> <sHL3z-74K-5@gated-at.bofh.it> <sHLdf-77O-3@gated-at.bofh.it> <sMsMF-3hS-1@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "hpa@zytor.com" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>, "bp@suse.de" <bp@suse.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "Daniluk, Lukasz" <lukasz.daniluk@intel.com>, "Cownie, James H" <james.h.cownie@intel.com>, "Pan, Jacob jun" <jacob.jun.pan@intel.com>, "Luc, Piotr" <Piotr.Luc@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 3 Feb 2017 11:47:40 +0100
X-Original-Message-ID	<20170203104740.GA30941@amd>
X-Original-References	<1477576923-3244-1-git-send-email-grzegorz.andrejczuk@intel.com> <1477576923-3244-3-git-send-email-grzegorz.andrejczuk@intel.com> <alpine.DEB.2.20.1610271625410.4817@nanos> <20161126131542.GB20568@xo-6d-61-c0.localdomain> <alpine.DEB.2.20.1611261420400.3602@nanos> <ED52C51D9B87F54892CE544909A13C6C1FF85E6E@IRSMSX101.ger.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1573023

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri 2016-12-09 12:49:33, Andrejczuk, Grzegorz wrote:
> > > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > > > +#ifdef CONFIG_X86_64
> > > > > +static int phi_r3mwait_disabled __read_mostly;
> > > > > +
> > > > > +static int __init phir3mwait_disable(char *__unused) {
> > > > > +	phi_r3mwait_disabled = 1;
> > > > > +	pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> > > > 
> > > > Why would that be a warning? The sysadmin added the command line 
> > > > switch, so why does he needs to be warned?
> > > 
> > > Its telling admin he did not make a typo on the command line. We often do that....
> >
> > Definitely not at the warning level.
> 
> Is info level OK for that message?

I'd say so.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Pavel Machek <pavel@ucw.cz> - 2017-02-03 11:50 +0100
  RE: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com> - 2017-02-03 12:30 +0100

csiph-web