Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572990

[PATCH v5 0/3] modversions: redefine kcrctab entries as 32-bit values

Show all headers | View raw

This v4 is a followup to [0] 'modversions: redefine kcrctab entries as
relative CRC pointers', but since relative CRC pointers do not work in
modules, and are actually only needed by powerpc with CONFIG_RELOCATABLE=y,
I have made it a Kconfig selectable feature instead.

Patch #1 introduces the MODULE_REL_CRCS Kconfig symbol, and adds the kbuild
handling of it, i.e., modpost, genksyms and kallsyms.

Patch #2 switches all architectures to 32-bit CRC entries in kcrctab, where
all architectures except powerpc with CONFIG_RELOCATABLE=y use absolute ELF
symbol references as before.

v5: make MODULE_REL_CRCS apply to both vmlinux and modules when selected
    reinstate Rusty's ack on #2, given that it is now mostly identical again
    to the patch he acked 3 months ago

v4: make relative CRCs kconfig selectable
    use absolute CRC symbols in modules regardless of kconfig selection
    split into two patches

v3: emit CRCs into .rodata rather than .rodata.modver, given that the latter
    will be emitted with read-write permissions, making the CRCs end up in a
    writable module segment.

    fold the modpost fix to ensure that the section address is only substracted
    from the symbol address when the ELF object in question is fully linked
    (i.e., ET_DYN or ET_EXEC, and not ET_REL)

v2: update modpost as well, so that genksyms no longer has to emit symbols
    for both the actual CRC value and the reference to where it is stored
    in the image

[0] http://marc.info/?l=linux-arch&m=148493613415294&w=2

Ard Biesheuvel (3):
  kbuild: modversions: add infrastructure for emitting relative CRCs
  modversions: treat symbol CRCs as 32 bit quantities
  module: unify absolute krctab definitions for 32-bit and 64-bit

 arch/powerpc/Kconfig              |  1 +
 arch/powerpc/include/asm/module.h |  4 --
 arch/powerpc/kernel/module_64.c   |  8 ---
 include/asm-generic/export.h      | 11 ++--
 include/linux/export.h            | 17 +++++--
 include/linux/module.h            | 14 +++---
 init/Kconfig                      |  4 ++
 kernel/module.c                   | 53 +++++++++-----------
 scripts/Makefile.build            |  2 +
 scripts/genksyms/genksyms.c       | 19 +++++--
 scripts/kallsyms.c                | 12 +++++
 scripts/mod/modpost.c             | 10 ++++
 12 files changed, 93 insertions(+), 62 deletions(-)

-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/3] modversions: redefine kcrctab entries as 32-bit values Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-02-03 11:00 +0100
  Re: [PATCH v5 0/3] modversions: redefine kcrctab entries as 32-bit values Linus Torvalds <torvalds@linux-foundation.org> - 2017-02-03 17:40 +0100

csiph-web