Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1572942
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq_info |
| Date | 2017-02-03 09:30 +0100 |
| Message-ID | <t6HpM-7CB-15@gated-at.bofh.it> (permalink) |
| References | <t49Vg-1J9-5@gated-at.bofh.it> <t4a4V-1M6-1@gated-at.bofh.it> <t6GWL-7cT-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Feb 03, 2017 at 03:54:36PM +0800, Jason Wang wrote:
>> + list_for_each_entry(vq, &vp_dev->vdev.vqs, list) {
>> + if (vq->callback && vring_interrupt(irq, vq) == IRQ_HANDLED)
>
> The check of vq->callback seems redundant, we will check it soon in
> vring_interrupt().
Good point - I wanted to keep things exactly as-is and dіdn't notice
we were already protected.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq_info Jason Wang <jasowang@redhat.com> - 2017-02-03 09:00 +0100 Re: [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq_info Christoph Hellwig <hch@lst.de> - 2017-02-03 09:30 +0100
csiph-web