Re: [PATCH v4 0/2] Add further ioctl() operations for namespace discovery

From	ebiederm@xmission.com (Eric W. Biederman)
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/2] Add further ioctl() operations for namespace discovery
Date	2017-02-03 03:40 +0100
Message-ID	<t6BX4-3Um-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <t3lF7-4at-5@gated-at.bofh.it> <t3lF7-4at-3@gated-at.bofh.it> <t3lF8-4at-13@gated-at.bofh.it> <t3mUx-4XL-3@gated-at.bofh.it> <t3JR7-2Lo-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

ebiederm@xmission.com (Eric W. Biederman) writes:

> "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes:
>
>
>> On 25 January 2017 at 15:28, Eric W. Biederman <ebiederm@xmission.com> wrote:
>
>>> My concern is that the difference between returning -EOVERFLOW and
>>> overflow_uid is primarily about usability.  If you haven't played with
>>> the usability I don't trust that we have made the proper trade off.
>>
>> So, I had not initially included the no-UID-mapping case, and when you
>> proposed -EOVERFLOW for that case, it seemed better.
>>
>> On reflection, mapping to the overflow_uid seems simpler. Taking the
>> example shown in my other mail a short time ago, the unmapped UID 0
>> from the outer namespace would map to the overflow_uid (which UID my
>> program would print), but my program would still correctly report that
>> the UID 0 process in the outer namespace might (subject to LSM checks)
>> have capabilities in the inner namespace.
>>
>> So, it seems that reverting the EOVERFLOW change is in order (and my
>> example program thus needs no changes). Does that sound reasonable to
>> you?
>
> It does.  I just care that you have thought through the tradeoffs of
> that corner of the interface design.

So I have just reverted the EOVERFLOW change, applied the patches to
my tree and pushed this to for-next.  Otherwise this looks like this
effort will have stalled.

Eric

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 0/2] Add further ioctl() operations for namespace discovery ebiederm@xmission.com (Eric W. Biederman) - 2017-02-03 03:40 +0100
  Re: [PATCH v4 0/2] Add further ioctl() operations for namespace discovery "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-02-08 16:30 +0100

csiph-web