Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571890

Re: [PATCH v3 18/24] media: imx: Add SMFC subdev driver

Show all headers | View raw

Hi Steve,

On Fri, Jan 06, 2017 at 06:11:36PM -0800, Steve Longerbeam wrote:
> +/*
> + * Min/Max supported width and heights.
> + *
> + * We allow planar output from the SMFC, so we have to align
> + * output width by 16 pixels to meet IDMAC alignment requirements,
> + * which also means input width must have the same alignment.
> + */
> +#define MIN_W       176
> +#define MIN_H       144
> +#define MAX_W      8192
> +#define MAX_H      4096
> +#define W_ALIGN    4 /* multiple of 16 pixels */

Does this only apply to planar formats?

I notice Philipp's driver allows 8 pixel alignment.  If it's only for
planar formats, it ought to determine the alignment based on the
requested format rather than hard-coding it to the maximum alignment
of all the supported formats.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 18/24] media: imx: Add SMFC subdev driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-01 19:50 +0100
  Re: [PATCH v3 18/24] media: imx: Add SMFC subdev driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-02-01 20:00 +0100

csiph-web