Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571857

Re: [PATCH 1/3] arc: vdk: Disable halt on reset

Show all headers | View raw

Hi Vineet,

On Wed, 2017-02-01 at 09:37 -0800, Vineet Gupta wrote:
> On 02/01/2017 09:14 AM, Alexey Brodkin wrote:
> > 
> > > 
> > > > 
> > > > -# CONFIG_ARC_TIMERS_64BIT is not set
> > > 
> > > Are you sure abut this part. Ater the timers driver rework, this would enable GFRC
> > > for SMP builds and AFAIKR there were some issues with time with GFRC + nSIM etc..
> > 
> > Not anymore :)
> > 
> > Probably I missed something in discussions.
> 
> STAR 9000879565, 9000879563
> 
> > 
> > As a matter of fact I did run-test resulting vmlinux and it worked very nice.
> > More over ARC_TIMERS_64BIT is selected automatically by ISA_ARCV2, see
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/Kconfig#n119
> > 
> > That said even if "# CONFIG_ARC_TIMERS_64BIT is not set" is left in place the option will be
> > effectively enabled, no?
> 
> The whole point of adding this to defconfig is to override the default from Kconfig ?

Not anymore :)

Since commit c4c9a040ecb7 ("clocksource: import ARC timer driver"),
see http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c4c9a040ecb7297e011e579f5a9cc280e42d725f
we have this:
---------------------->8----------------------
config ISA_ARCV2
	bool "ARC ISA v2"
	select ARC_TIMERS_64BIT
---------------------->8----------------------

which really means if one selects ISA_ARCV2 then ARC_TIMERS_64BIT gets selected automatically
and there's no way to override it from either menuconfig or defconfig.

Probably behavior that you meant was to keep a separate "config ARC_TIMERS_64BIT"
and have it "default y if ISA_ARCV2".

-Alexey

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] arc: vdk: Disable halt on reset Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-01 17:50 +0100
  Re: [PATCH 1/3] arc: vdk: Disable halt on reset Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-02-01 18:00 +0100
    Re: [PATCH 1/3] arc: vdk: Disable halt on reset Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-01 18:20 +0100
      Re: [PATCH 1/3] arc: vdk: Disable halt on reset Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-02-01 18:40 +0100
        Re: [PATCH 1/3] arc: vdk: Disable halt on reset Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-01 19:00 +0100
          Re: [PATCH 1/3] arc: vdk: Disable halt on reset Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-02-01 21:00 +0100
            RE: [PATCH 1/3] arc: vdk: Disable halt on reset Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-01 21:10 +0100
            RE: [PATCH 1/3] arc: vdk: Disable halt on reset Ruud Derwig <Ruud.Derwig@synopsys.com> - 2017-02-02 15:10 +0100

csiph-web