Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1571764

Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code

From Will Deacon <will.deacon@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code
Date 2017-02-01 18:10 +0100
Message-ID <t66zT-fo-5@gated-at.bofh.it> (permalink)
References <t3y9k-3Do-9@gated-at.bofh.it> <t3y9k-3Do-7@gated-at.bofh.it> <t3BJT-5ZU-1@gated-at.bofh.it> <t4fxD-5cg-11@gated-at.bofh.it> <t66zT-fo-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Feb 01, 2017 at 05:02:43PM +0000, Punit Agrawal wrote:
> Will Deacon <will.deacon@arm.com> writes:
> 
> > On Wed, Jan 25, 2017 at 08:39:43PM +0100, Christoffer Dall wrote:
> >> On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote:
> >> > Refactor the KVM code to use the __tlbi macros, which will allow an errata
> >> > workaround that repeats tlbi dsb sequences to only change one location.
> >> > This is not intended to change the generated assembly and comparing before
> >> > and after vmlinux objdump shows no functional changes.
> >> > 
> >> > Signed-off-by: Christopher Covington <cov@codeaurora.org>
> >> 
> >> Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
> >
> > Thanks, I'll queue this one via arm64.
> 
> I just noticed this patch but there's been a similar patch from Mark
> that I've been carrying as part of the KVM TLB monitoring series[0].
> 
> [0] http://www.mail-archive.com/kvmarm@lists.cs.columbia.edu/msg09359.html

Well I've already queued the one from Christopher. It's weird that Mark's
version appears to miss the local VMID case (but it does have the
flush_icache_all I wanted :).

Anyway, I'm not reverting anything, so you'll need to rebase when this
lot lands in mainline.

Will

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Will Deacon <will.deacon@arm.com> - 2017-02-01 18:10 +0100
  Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Punit Agrawal <punit.agrawal@arm.com> - 2017-02-01 18:20 +0100

csiph-web