Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1571705
| From | Bjorn Helgaas <bhelgaas@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 1/2] drm/amdgpu: remove unnecessary save/restore of pdev->d3_delay |
| Date | 2017-02-01 17:30 +0100 |
| Message-ID | <t65Xd-8e7-33@gated-at.bofh.it> (permalink) |
| References | <t65Xc-8e7-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Remove unnecessary save/restore of pdev->d3_delay.
The only assignments to pdev->d3_delay are in radeon_switcheroo_set_state()
and some quirks, none of which should be relevant in the
amdgpu_switcheroo_set_state() path.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 60bd4afe45c8..3a403a87ec62 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1042,16 +1042,12 @@ static void amdgpu_switcheroo_set_state(struct pci_dev *pdev, enum vga_switchero
return;
if (state == VGA_SWITCHEROO_ON) {
- unsigned d3_delay = dev->pdev->d3_delay;
-
printk(KERN_INFO "amdgpu: switched on\n");
/* don't suspend or resume card normally */
dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;
amdgpu_device_resume(dev, true, true);
- dev->pdev->d3_delay = d3_delay;
-
dev->switch_power_state = DRM_SWITCH_POWER_ON;
drm_kms_helper_poll_enable(dev);
} else {
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/2] drm amdgpu/radeon: clean up d3_delay usage Bjorn Helgaas <bhelgaas@google.com> - 2017-02-01 17:30 +0100 [PATCH v2 1/2] drm/amdgpu: remove unnecessary save/restore of pdev->d3_delay Bjorn Helgaas <bhelgaas@google.com> - 2017-02-01 17:30 +0100 [PATCH v2 2/2] drm/radeon: make MacBook Pro d3_delay quirk more generic Bjorn Helgaas <bhelgaas@google.com> - 2017-02-01 17:30 +0100 Re: [PATCH v2 0/2] drm amdgpu/radeon: clean up d3_delay usage Andreas Boll <andreas.boll.dev@gmail.com> - 2017-02-01 17:40 +0100
csiph-web