Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1571594
| Path | csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Lee Jones <lee.jones@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [Resend PATCH v2 1/3] dt-bindings: mfd: stm32f4: Fix STM32F4_X_CLOCK() macro |
| Date | Wed, 01 Feb 2017 15:40:02 +0100 |
| Message-ID | <t64eK-77f-33@gated-at.bofh.it> (permalink) |
| References | <t62Zj-6rB-3@gated-at.bofh.it> <t62Zj-6rB-13@gated-at.bofh.it> |
| X-Original-To | gabriel.fernandez@st.com |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oaPLA01venirxyE22N+TPzXExO6CG2QdXH/dWh1E1vc=; b=OJtKfxw94yjRLIbdBAKuH0DLNq9bS/XQVHy62CZYcRC0e9b2JXhhVf6/m+58Dw6CzO SVHHpM4nhCZldDc80q/ASz9NXbKiXqQN2sKLsod+1QMxFggeLKMktDiXcVFlpAIF4uVG ifd9niEVK5fxwEXMFlYpSELV9bgfL7MirHt+0= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=oaPLA01venirxyE22N+TPzXExO6CG2QdXH/dWh1E1vc=; b=kNg1gmbdqihNRFEmr2SyZvgBhL89hBIdyZ2LLb7cJ9RePrA5SUKLCyvR5YDrqe5mks tsb/PHmiezJmRWU69nu6NuQgchKipkoibZ8HMsG+NYqhKHfygpOIIyaHAB66e+tkBS85 xiHGm6EQyi8MpVfZl7DK+JT8TBxQp8HvfLmQ5Q8Dq5/5sCErIssSpJykgAxK4rymHN6i dYmyLNXYR3tKxVNoFdcSnNN6xzCpXYkA/noeenY2ebKXv7MCWdMd64p+Z9Hh4F+FGkio YeE2n/lhgisBN3tAn+L9WAXTm6OKe6b1UBxY/hEKZdHphP6tlhvj67KSg6PXlhmZSbJk /lrA== |
| X-Gm-Message-State | AIkVDXK3AOAUyd6+dq9dkfvGNsqu/uZDzhzkv7GKYXi8IzNYvUbbAb2H/a4w55+Rvv4NFqE7 |
| X-Received | by 10.223.133.131 with SMTP id 3mr2887243wrt.161.1485959736412; Wed, 01 Feb 2017 06:35:36 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Disposition | inline |
| Content-Transfer-Encoding | 8bit |
| User-Agent | Mutt/1.6.2-neo (2016-08-21) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 71 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Nicolas Pitre <nico@linaro.org>, Arnd Bergmann <arnd@arndb.de>, daniel.thompson@linaro.org, andrea.merello@gmail.com, radoslaw.pietrzyk@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ludovic.barre@st.com, olivier.bideau@st.com, amelie.delaunay@st.com |
| X-Original-Date | Wed, 1 Feb 2017 14:35:33 +0000 |
| X-Original-Message-ID | <20170201143533.pxwe6gmfcymmsy4p@dell> |
| X-Original-References | <1485954596-11014-1-git-send-email-gabriel.fernandez@st.com> <1485954596-11014-2-git-send-email-gabriel.fernandez@st.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1571594 |
Show key headers only | View raw
On Wed, 01 Feb 2017, gabriel.fernandez@st.com wrote: > From: Gabriel Fernandez <gabriel.fernandez@st.com> > > Macro to select a clock was not correct. > > Offset of enable register starts at 0x30, then calculation to select a bit is: > (@enable_reg - 0x30) / 4 * 32 + bit_to_select > > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com> > Tested-by: M'boumba Cedric Madianga <cedric.madianga@gmail.com> > Acked-by: Stephen Boyd <sboyd@codeaurora.org> > > --- > include/dt-bindings/mfd/stm32f4-rcc.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h > index e98942d..f662b19 100644 > --- a/include/dt-bindings/mfd/stm32f4-rcc.h > +++ b/include/dt-bindings/mfd/stm32f4-rcc.h > @@ -25,7 +25,7 @@ > #define STM32F4_RCC_AHB1_OTGHS 29 > > #define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8)) > -#define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit + (0x30 * 8)) > +#define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit) > > > /* AHB2 */ > @@ -36,13 +36,13 @@ > #define STM32F4_RCC_AHB2_OTGFS 7 > > #define STM32F4_AHB2_RESET(bit) (STM32F4_RCC_AHB2_##bit + (0x14 * 8)) > -#define STM32F4_AHB2_CLOCK(bit) (STM32F4_RCC_AHB2_##bit + (0x34 * 8)) > +#define STM32F4_AHB2_CLOCK(bit) (STM32F4_RCC_AHB2_##bit + 0x20) > > /* AHB3 */ > #define STM32F4_RCC_AHB3_FMC 0 > > #define STM32F4_AHB3_RESET(bit) (STM32F4_RCC_AHB3_##bit + (0x18 * 8)) > -#define STM32F4_AHB3_CLOCK(bit) (STM32F4_RCC_AHB3_##bit + (0x38 * 8)) > +#define STM32F4_AHB3_CLOCK(bit) (STM32F4_RCC_AHB3_##bit + 0x40) > > /* APB1 */ > #define STM32F4_RCC_APB1_TIM2 0 > @@ -72,7 +72,7 @@ > #define STM32F4_RCC_APB1_UART8 31 > > #define STM32F4_APB1_RESET(bit) (STM32F4_RCC_APB1_##bit + (0x20 * 8)) > -#define STM32F4_APB1_CLOCK(bit) (STM32F4_RCC_APB1_##bit + (0x40 * 8)) > +#define STM32F4_APB1_CLOCK(bit) (STM32F4_RCC_APB1_##bit + 0x80) > > /* APB2 */ > #define STM32F4_RCC_APB2_TIM1 0 > @@ -93,6 +93,6 @@ > #define STM32F4_RCC_APB2_LTDC 26 > > #define STM32F4_APB2_RESET(bit) (STM32F4_RCC_APB2_##bit + (0x24 * 8)) > -#define STM32F4_APB2_CLOCK(bit) (STM32F4_RCC_APB2_##bit + (0x44 * 8)) > +#define STM32F4_APB2_CLOCK(bit) (STM32F4_RCC_APB2_##bit + 0xA0) > > #endif /* _DT_BINDINGS_MFD_STM32F4_RCC_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[Resend PATCH v2 1/3] dt-bindings: mfd: stm32f4: Fix STM32F4_X_CLOCK() macro <gabriel.fernandez@st.com> - 2017-02-01 14:20 +0100 Re: [Resend PATCH v2 1/3] dt-bindings: mfd: stm32f4: Fix STM32F4_X_CLOCK() macro Lee Jones <lee.jones@linaro.org> - 2017-02-01 15:40 +0100
csiph-web