Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571570

Re: [PATCH] virtio-console: avoid DMA from stack

Show all headers | View raw

On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> put_chars() stuffs the buffer it gets into an sg, but that buffer may be
> on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
> manifested as printks getting turned into NUL bytes).

Seems reasonable.  I wonder since all implementations of hvc do a
memcpy, if we can abstract it - but that'll need some work.

Reviewed-by: Amit Shah <amit.shah@redhat.com>

Michael, please add to the virtio queue.

		Amit

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] virtio-console: avoid DMA from stack Omar Sandoval <osandov@osandov.com> - 2017-02-01 09:10 +0100
  Re: [PATCH] virtio-console: avoid DMA from stack Amit Shah <amit.shah@redhat.com> - 2017-02-01 14:50 +0100

csiph-web