Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros for tracepoints iteration

From	Taeung Song <treeze.taeung@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros for tracepoints iteration
Date	2017-01-31 03:50 +0100
Message-ID	<t5wG5-3rw-3@gated-at.bofh.it> (permalink)
References	<t5fFf-1Jp-5@gated-at.bofh.it> <t5g8i-28g-19@gated-at.bofh.it> <t5hxp-2QU-39@gated-at.bofh.it> <t5jzc-42b-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 01/30/2017 09:38 PM, Jiri Olsa wrote:
> On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:
>
> SNIP
>
>>> looks almost the same as for_each_event_system macro,
>>> what's the difference other than 'ftrace' check?
>>
>> Little thing.
>> In parse-events.c for_each_event macro contains
>> tp_event_has_id() function But this function isn't used in
>> util/trace-event-info.c
>>
>>> also why's one 'file' and the other 'system'? looks
>>
>> Just, I follow the name of each function that use the macros..
>>
>>> like we coud have just one macro in here
>>>
>>
>> I understood. :)
>> How about this ?
>
>
> looks ok, but can't apply it.. it's probably mangled
>

I got it.
I'll resend this changed patch!

Thanks,
Taeung

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf tools: Create for_each_event{_system, _file} macros for tracepoints iteration Taeung Song <treeze.taeung@gmail.com> - 2017-01-30 09:40 +0100
  Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros  for tracepoints iteration Jiri Olsa <jolsa@redhat.com> - 2017-01-30 10:10 +0100
    Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros  for tracepoints iteration Taeung Song <treeze.taeung@gmail.com> - 2017-01-30 11:40 +0100
      Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros  for tracepoints iteration Jiri Olsa <jolsa@redhat.com> - 2017-01-30 13:50 +0100
        Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros  for tracepoints iteration Taeung Song <treeze.taeung@gmail.com> - 2017-01-31 03:50 +0100

csiph-web