Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1570204

Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced

From Bjorn Helgaas <helgaas@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced
Date 2017-01-31 01:20 +0100
Message-ID <t5ukV-2bV-13@gated-at.bofh.it> (permalink)
References <t32VP-Mf-7@gated-at.bofh.it> <t32VQ-Mf-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jan 24, 2017 at 03:05:21PM +0800, zhichang.yuan wrote:
> Low-pin-count interface is integrated into some SoCs. The accesses to those
> peripherals under LPC make use of I/O ports rather than the memory mapped I/O.
> 
> To drive these devices, this patch introduces a method named indirect-IO.

It's slightly confusing to call this "indirect I/O" and then use
"extio" for the filename and function prefix.  It'd be nice to use
related names.

> +struct extio_node {
> +	unsigned long bus_start;	/* bus start address */
> +	unsigned long io_start;	/* io port token corresponding to bus_start */
> +	size_t range_size;	/* size of the extio node operating range */
> +	struct fwnode_handle *fwnode;
> +	struct list_head list;
> +	struct extio_ops *ops;	/* ops operating on this node */
> +	void *devpara;	/* private parameter of the host device */
> +};

I wish we didn't have both struct io_range and struct extio_node.  It
seems like they're both sort of trying to do the same thing.  Maybe
this is the same as what Alex is saying.

Bjorn

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V6 0/5] LPC: legacy ISA I/O support "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-01-24 07:40 +0100
  [PATCH V6 4/5] LPC: Support the device-tree LPC host on Hip06/Hip07 "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-01-24 07:40 +0100
    Re: [PATCH V6 4/5] LPC: Support the device-tree LPC host on  Hip06/Hip07 Rob Herring <robh@kernel.org> - 2017-01-27 23:20 +0100
    Re: [PATCH V6 4/5] LPC: Support the device-tree LPC host on  Hip06/Hip07 Alexander Graf <agraf@suse.de> - 2017-01-30 21:20 +0100
      Re: [PATCH V6 4/5] LPC: Support the device-tree LPC host on  Hip06/Hip07 John Garry <john.garry@huawei.com> - 2017-01-31 11:20 +0100
        Re: [PATCH V6 4/5] LPC: Support the device-tree LPC host on  Hip06/Hip07 Alexander Graf <agraf@suse.de> - 2017-01-31 12:20 +0100
          Re: [PATCH V6 4/5] LPC: Support the device-tree LPC host on  Hip06/Hip07 John Garry <john.garry@huawei.com> - 2017-01-31 13:00 +0100
          RE: [PATCH V6 4/5] LPC: Support the device-tree LPC host on  Hip06/Hip07 Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-01-31 13:00 +0100
      Re: [PATCH V6 4/5] LPC: Support the device-tree LPC host on  Hip06/Hip07 "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-02-13 15:50 +0100
  [PATCH V6 3/5] OF: Add missing I/O range exception for indirect-IO  devices "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-01-24 07:40 +0100
    Re: [PATCH V6 3/5] OF: Add missing I/O range exception for  indirect-IO  devices Rob Herring <robh@kernel.org> - 2017-01-27 23:10 +0100
      Re: [PATCH V6 3/5] OF: Add missing I/O range exception for  indirect-IO devices John Garry <john.garry@huawei.com> - 2017-01-30 10:10 +0100
        Re: [PATCH V6 3/5] OF: Add missing I/O range exception for  indirect-IO devices Arnd Bergmann <arnd@arndb.de> - 2017-01-30 11:20 +0100
  [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-01-24 07:40 +0100
    Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced Alexander Graf <agraf@suse.de> - 2017-01-30 18:20 +0100
      Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced John Garry <john.garry@huawei.com> - 2017-01-31 14:50 +0100
        Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced Alexander Graf <agraf@suse.de> - 2017-01-31 20:40 +0100
          RE: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-02-01 13:40 +0100
          Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-02-13 15:30 +0100
      Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-02-13 15:10 +0100
    Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced Bjorn Helgaas <helgaas@kernel.org> - 2017-01-31 01:20 +0100
      Re: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced John Garry <john.garry@huawei.com> - 2017-01-31 14:50 +0100
  [PATCH V5 5/5] LPC: Add the ACPI LPC support "zhichang.yuan" <yuanzhichang@hisilicon.com> - 2017-01-24 07:40 +0100
    Re: [PATCH V5 5/5] LPC: Add the ACPI LPC support John Garry <john.garry@huawei.com> - 2017-02-04 14:30 +0100

csiph-web