Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570194

Re: [PATCH 2/2] mm: vmpressure: fix sending wrong events on underflow

From Minchan Kim <minchan@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] mm: vmpressure: fix sending wrong events on underflow
Date 2017-01-31 01:10 +0100
Message-ID <t5ubg-28G-21@gated-at.bofh.it> (permalink)
References <t49Vg-1J9-7@gated-at.bofh.it> <t49Vh-1J9-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 27, 2017 at 01:43:37PM +0530, Vinayak Menon wrote:
> At the end of a window period, if the reclaimed pages
> is greater than scanned, an unsigned underflow can
> result in a huge pressure value and thus a critical event.
> Reclaimed pages is found to go higher than scanned because
> of the addition of reclaimed slab pages to reclaimed in
> shrink_node without a corresponding increment to scanned
> pages. Minchan Kim mentioned that this can also happen in
> the case of a THP page where the scanned is 1 and reclaimed
> could be 512.
> 
> Signed-off-by: Vinayak Menon <vinmenon@codeaurora.org>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks for the fix up!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2 v2] mm: vmscan: do not pass reclaimed slab to vmpressure Vinayak Menon <vinmenon@codeaurora.org> - 2017-01-27 09:20 +0100
  [PATCH 2/2] mm: vmpressure: fix sending wrong events on underflow Vinayak Menon <vinmenon@codeaurora.org> - 2017-01-27 09:20 +0100
    Re: [PATCH 2/2] mm: vmpressure: fix sending wrong events on underflow Minchan Kim <minchan@kernel.org> - 2017-01-31 01:10 +0100
  Re: [PATCH 1/2 v2] mm: vmscan: do not pass reclaimed slab to  vmpressure Minchan Kim <minchan@kernel.org> - 2017-01-31 01:00 +0100
    Re: [PATCH 1/2 v2] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-01-31 08:50 +0100
  [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to vmpressure Vinayak Menon <vinmenon@codeaurora.org> - 2017-01-31 10:10 +0100
    Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to  vmpressure Minchan Kim <minchan@kernel.org> - 2017-02-01 07:20 +0100
    Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-02 11:50 +0100
      Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-02 11:50 +0100
        Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-02 12:30 +0100
          Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-02 13:00 +0100
            Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-02 16:40 +0100
              Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-02 17:10 +0100
                Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-03 06:30 +0100
                Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-03 16:10 +0100
                Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-06 12:40 +0100
      Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-02 12:30 +0100
      Re: [PATCH 1/2 v3] mm: vmscan: do not pass reclaimed slab to  vmpressure Minchan Kim <minchan@kernel.org> - 2017-02-03 07:20 +0100

csiph-web