Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning
Date	2017-01-30 20:20 +0100
Message-ID	<t5pEC-7OD-35@gated-at.bofh.it> (permalink)
References	<t3wKd-2S1-3@gated-at.bofh.it> <t3wKd-2S1-1@gated-at.bofh.it> <t3wTT-2VB-17@gated-at.bofh.it> <t3wTU-2VB-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 25 Jan 2017 15:35:32 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Jan 25, 2017 at 03:32:11PM +0100, Alexander Potapenko wrote:
> 
> > > @@ -300,6 +301,8 @@ void kasan_report(unsigned long addr, size_t size,
> > >         if (likely(!kasan_report_enabled()))
> > >                 return;
> > >
> > > +       disable_trace_on_warning();
> > > +  
> > Who is going to enable tracing back after we're done?  
> 
> The user..

Yep,

 # echo 1 > /sys/kernel/debug/tracing/tracing_on

Re-enables tracing.

-- Steve

> 
> > Note that KASAN errors are not fatal, and the first one may possibly
> > occur quite early.  
> 
> WARN*() isn't fatal either, and it does the same thing. Note that
> traceoff_on_warning is default disabled. You have to explicitly request
> this.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Peter Zijlstra <peterz@infradead.org> - 2017-01-25 15:30 +0100
  Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Alexander Potapenko <glider@google.com> - 2017-01-25 15:40 +0100
    Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Alexander Potapenko <glider@google.com> - 2017-01-25 15:40 +0100
    Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Peter Zijlstra <peterz@infradead.org> - 2017-01-25 15:40 +0100
      Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Steven Rostedt <rostedt@goodmis.org> - 2017-01-30 20:20 +0100

csiph-web