Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569955

Re: [PATCH] Staging: omap4iss: fix coding style issues

Show all headers | View raw

Hello Avraham,

Thank you for the patch.

On Saturday 28 Jan 2017 20:00:08 Avraham Shukron wrote:
> This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c
> Specifically, it fixes "line over 80 characters" issues
> 
> Signed-off-by: Avraham Shukron <avraham.shukron@gmail.com>

This looks OK to me. I've applied the patch to my tree and will push it to 
v4.11.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/staging/media/omap4iss/iss_video.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss_video.c
> b/drivers/staging/media/omap4iss/iss_video.c index c16927a..cdab053 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -298,7 +298,8 @@ iss_video_check_format(struct iss_video *video, struct
> iss_video_fh *vfh)
> 
>  static int iss_video_queue_setup(struct vb2_queue *vq,
>  				 unsigned int *count, unsigned int 
*num_planes,
> -				 unsigned int sizes[], struct device 
*alloc_devs[])
> +				 unsigned int sizes[],
> +				 struct device *alloc_devs[])
>  {
>  	struct iss_video_fh *vfh = vb2_get_drv_priv(vq);
>  	struct iss_video *video = vfh->video;
> @@ -678,8 +679,8 @@ iss_video_get_selection(struct file *file, void *fh,
> struct v4l2_selection *sel) if (subdev == NULL)
>  		return -EINVAL;
> 
> -	/* Try the get selection operation first and fallback to get format if 
not
> -	 * implemented.
> +	/* Try the get selection operation first and fallback to get format if
> +	 * not implemented.
>  	 */
>  	sdsel.pad = pad;
>  	ret = v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel);

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: omap4iss: fix coding style issues Avraham Shukron <avraham.shukron@gmail.com> - 2017-01-28 19:20 +0100
  Re: [PATCH] Staging: omap4iss: fix coding style issues Ozgur Karatas <okaratas@member.fsf.org> - 2017-01-29 08:40 +0100
    Re: [PATCH] Staging: omap4iss: fix coding style issues Avraham Shukron <avraham.shukron@gmail.com> - 2017-01-30 00:00 +0100
  Re: [PATCH] Staging: omap4iss: fix coding style issues Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-01-30 18:50 +0100
    Re: [PATCH] Staging: omap4iss: fix coding style issues Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-01-31 11:50 +0100
      [PATCH v2] Staging: omap4iss: Fix coding style issues Avraham Shukron <avraham.shukron@gmail.com> - 2017-02-06 19:10 +0100
        Re: [PATCH v2] Staging: omap4iss: Fix coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-02-07 09:20 +0100
          [PATCH v3 1/2] staging: omap4iss: fix multiline comment style Avraham Shukron <avraham.shukron@gmail.com> - 2017-02-07 16:50 +0100
            Re: [PATCH v3 1/2] staging: omap4iss: fix multiline comment style Greg KH <gregkh@linuxfoundation.org> - 2017-02-09 12:20 +0100
              [PATCH v4 1/2] staging: omap4iss: fix multiline comment style Avraham Shukron <avraham.shukron@gmail.com> - 2017-02-09 18:00 +0100
                [PATCH v4 2/2] staging: omap4iss: fix coding style issue Avraham Shukron <avraham.shukron@gmail.com> - 2017-02-09 18:20 +0100
                Re: [PATCH v4 1/2] staging: omap4iss: fix multiline comment style Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-02-10 09:00 +0100
    Re: [PATCH] Staging: omap4iss: fix coding style issues Sakari Ailus <sakari.ailus@iki.fi> - 2017-01-31 11:50 +0100

csiph-web