Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes.

From	Rob Herring <robh+dt@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes.
Date	2017-01-30 18:00 +0100
Message-ID	<t5nt8-6kA-19@gated-at.bofh.it> (permalink)
References	<t2ZEB-77l-3@gated-at.bofh.it> <t2ZEB-77l-1@gated-at.bofh.it> <t4nOx-1Xx-7@gated-at.bofh.it> <t4rfr-3Vi-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 27, 2017 at 8:41 PM, Eric Anholt <eric@anholt.net> wrote:
> Rob Herring <robh+dt@kernel.org> writes:
>
>> Need to cc DT list if you want it in my queue.
>>
>> On Mon, Jan 23, 2017 at 6:38 PM, Eric Anholt <eric@anholt.net> wrote:
>>> These are part of the vc4 display pipeline.
>>>
>>> Signed-off-by: Eric Anholt <eric@anholt.net>
>>> ---
>>>  .../devicetree/bindings/display/brcm,bcm-vc4.txt   | 35 ++++++++++++++++++++++
>>>  1 file changed, 35 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
>>> index e2768703ac2b..34c7fddcea39 100644
>>> --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
>>> +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
>>> @@ -56,6 +56,18 @@ Required properties for V3D:
>>>  - interrupts:  The interrupt number
>>>                   See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
>>>
>>> +Required properties for DSI:
>>> +- compatible:  Should be "brcm,bcm2835-dsi0" or "brcm,bcm2835-dsi1"
>>
>> Are the blocks different?
>
> They are from the same lineage, but very different (old dsi0 is 1 lane,
> dsi1 is 4 lanes).  You can see how much the registers move around and
> change in the dsi->port conditional blocks in the driver code.

Okay, can you add a note here with this detail. With that,

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes. Eric Anholt <eric@anholt.net> - 2017-01-24 04:10 +0100
  Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes. Rob Herring <robh+dt@kernel.org> - 2017-01-28 00:10 +0100
    Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes. Eric Anholt <eric@anholt.net> - 2017-01-28 03:50 +0100
      Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes. Rob Herring <robh+dt@kernel.org> - 2017-01-30 18:00 +0100

csiph-web