Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined
Date	2017-01-30 17:00 +0100
Message-ID	<t5mx3-5LI-5@gated-at.bofh.it> (permalink)
References	<t3xmV-3lm-3@gated-at.bofh.it> <t3xmX-3lm-55@gated-at.bofh.it> <t3OnM-5wh-11@gated-at.bofh.it> <t5lKF-5uN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon 30-01-17 22:59:52, Yisheng Xie wrote:
> Hi， Michal，
> Sorry for late reply.
> 
> On 01/26/2017 05:18 PM, Michal Hocko wrote:
> > On Wed 25-01-17 23:05:37, ysxie@foxmail.com wrote:
> >> From: Yisheng Xie <xieyisheng1@huawei.com>
> >>
> >> Define isolate_movable_page as a static inline function when
> >> CONFIG_MIGRATION is not enable. It should return false
> >> here which means failed to isolate movable pages.
> >>
> >> This patch do not have any functional change but prepare for
> >> later patch.
> > I think it would make more sense to make isolate_movable_page return int
> > and have the same semantic as __isolate_lru_page. This would be a better
> > preparatory patch for the later work.
> Yes, I think you are right, it is better to make isolate_movable_page return int
> just as what isolate_lru_page do, to make a better code style.
> 
> It seems Andrew had already merged the fixed patch from Arnd Bergmann,
> Maybe I can rewrite it in a later patch if it is suitable :)

I guess Andrew can just drop the current series with the folow up fixes
and wait for your newer version.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/2] HWPOISON: soft offlining for non-lru movable page ysxie@foxmail.com - 2017-01-25 16:10 +0100
  [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined ysxie@foxmail.com - 2017-01-25 16:10 +0100
    Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always  defined Michal Hocko <mhocko@kernel.org> - 2017-01-26 10:20 +0100
      Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always  defined Yisheng Xie <ysxie@foxmail.com> - 2017-01-30 16:10 +0100
        Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always  defined Michal Hocko <mhocko@kernel.org> - 2017-01-30 17:00 +0100

csiph-web