Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569714

Re: [PATCH] Gpu: drm: exynos - Fix possible NULL derefrence.

Show all headers | View raw

Hello Shailendra,

The subject line is wrong, please always use the convention used in
previous commits, i.e: git log --oneline drivers/gpu/drm/exynos/

On 01/30/2017 02:02 AM, Shailendra Verma wrote:
> of_device_get_match_data could return NULL, and so can cause
> a NULL pointer dereference later.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c  |    4 ++++
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c |    4 ++++
>  drivers/gpu/drm/exynos/exynos_hdmi.c     |    4 ++++
>  drivers/gpu/drm/exynos/exynos_mixer.c    |    4 ++++
>  4 files changed, 16 insertions(+)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index e07cb1f..fba0ffc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1765,6 +1765,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
>  
>  	dsi->dev = dev;
>  	dsi->driver_data = of_device_get_match_data(dev);
> +	if (!dsi->driver_data) {
> +		dev_err(dev, "no device match found\n");
> +		return -ENODEV;
> +	}
>

I don't think this makes sense for the Exynos driver since Exynos is a
DT-only platform and so the probe callback can only be called if a dev
node with a compatible string in the OF device id table was registered.

All the struct of_device_id in the table have a .data and so this can't
be NULL in this driver.
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Gpu: drm: exynos - Fix possible NULL derefrence. Shailendra Verma <shailendra.v@samsung.com> - 2017-01-30 06:20 +0100
  Re: [PATCH] Gpu: drm: exynos - Fix possible NULL derefrence. Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-30 14:00 +0100

csiph-web