[tip:sched/core] sched/core: Fix &rd->rto_mask memory leak

From	tip-bot for Mathieu Poirier <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:sched/core] sched/core: Fix &rd->rto_mask memory leak
Date	2017-01-30 13:00 +0100
Message-ID	<t5iMP-3x0-45@gated-at.bofh.it> (permalink)
References	<t3gFs-ZY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  92c99ac829931abba33107e09358447c8ad6bd32
Gitweb:     http://git.kernel.org/tip/92c99ac829931abba33107e09358447c8ad6bd32
Author:     Mathieu Poirier <mathieu.poirier@linaro.org>
AuthorDate: Tue, 24 Jan 2017 14:11:34 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 30 Jan 2017 11:46:36 +0100

sched/core: Fix &rd->rto_mask memory leak

If function cpudl_init() fails the memory allocated for &rd->rto_mask
needs to be freed, something this patch is addressing.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1485292295-21298-1-git-send-email-mathieu.poirier@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 3b248b0..17d1df6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5976,7 +5976,7 @@ static int init_rootdomain(struct root_domain *rd)
 
 	init_dl_bw(&rd->dl_bw);
 	if (cpudl_init(&rd->cpudl) != 0)
-		goto free_dlo_mask;
+		goto free_rto_mask;
 
 	if (cpupri_init(&rd->cpupri) != 0)
 		goto free_rto_mask;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] sched/core: Fix &rd->rto_mask memory leak Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-01-24 22:20 +0100
  [PATCH 2/2] sched/core: Fix &rd->cpudl memory leak Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-01-24 22:20 +0100
    [tip:sched/core] sched/core: Fix &rd->cpudl memory leak tip-bot for Mathieu Poirier <tipbot@zytor.com> - 2017-01-30 13:00 +0100
  [tip:sched/core] sched/core: Fix &rd->rto_mask memory leak tip-bot for Mathieu Poirier <tipbot@zytor.com> - 2017-01-30 13:00 +0100

csiph-web