Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.

From	Gautham R Shenoy <ego@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.
Date	2017-01-30 12:50 +0100
Message-ID	<t5iD7-3th-5@gated-at.bofh.it> (permalink)
References	<t3rhw-7QP-7@gated-at.bofh.it> <t3rhw-7QP-23@gated-at.bofh.it> <t5b8C-7pH-11@gated-at.bofh.it> <t5epP-15B-1@gated-at.bofh.it> <t5ia5-3jQ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 30, 2017 at 10:17:50PM +1100, Michael Ellerman wrote:
> "Rafael J. Wysocki" <rafael@kernel.org> writes:
> 
> > On Mon, Jan 30, 2017 at 4:47 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
> >>
> >>> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
> >>>
> >>> In the current code for powernv_add_idle_states, there is a lot of code
> >>> duplication while initializing an idle state in powernv_states table.
> >>>
> >>> Add an inline helper function to populate the powernv_states[] table
> >>> for a given idle state. Invoke this for populating the "Nap",
> >>> "Fastsleep" and the stop states in powernv_add_idle_states.
> >>>
> >>> Acked-by: Balbir Singh <bsingharora@gmail.com>
> >>> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> >>> ---
> >>>  drivers/cpuidle/cpuidle-powernv.c | 89 +++++++++++++++++++++++----------------
> >>>  include/linux/cpuidle.h           |  1 +
> >>
> >> I was going to merge this, but I see you've touched cpuidle.h, so I feel
> >> like I should get an ACK from the cpuidle folks.
> >>
> >> It's a fairly uncontroversial change, but it's their API.
> >
> > OK, please add an ACK from me to it then.
> 
> Thanks.

Thanks Rafael and Michal.

> 
> cheers
> 
--
Thanks and Regards
gautham.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states. "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-01-25 09:40 +0100
  Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states. Michael Ellerman <mpe@ellerman.id.au> - 2017-01-30 04:50 +0100
    Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate  powernv idle states. "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-30 08:20 +0100
      Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states. Michael Ellerman <mpe@ellerman.id.au> - 2017-01-30 12:20 +0100
        Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate  powernv idle states. Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-01-30 12:50 +0100

csiph-web