Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1569507
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 0/6 v3] kvmalloc |
| Date | 2017-01-30 11:00 +0100 |
| Message-ID | <t5gUF-2oF-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Hi,
this has been previously posted here [1] and it received quite some
feedback. As a result the number of patches has grown again. We are at
9 patches right now. I have rebased the series on top of the current
next-20170130. There were some changes since the last posting, namely
a7f6c1b63b86 ("AppArmor: Use GFP_KERNEL for __aa_kvmalloc().") which
dropped GFP_NOIO from __aa_kvmalloc and d407bd25a204 ("bpf: don't
trigger OOM killer under pressure with map alloc") which has created a
kvmalloc alternative for bpf code. Both have been changed to use the mm
kvmalloc but it is worth noting this dependency during the merge window.
I hope there are no further obstacles to have this merged into the mmotm
tree and go in in the next merge window.
Original cover:
There are many open coded kmalloc with vmalloc fallback instances in
the tree. Most of them are not careful enough or simply do not care
about the underlying semantic of the kmalloc/page allocator which means
that a) some vmalloc fallbacks are basically unreachable because the
kmalloc part will keep retrying until it succeeds b) the page allocator
can invoke a really disruptive steps like the OOM killer to move forward
which doesn't sound appropriate when we consider that the vmalloc
fallback is available.
As it can be seen implementing kvmalloc requires quite an intimate
knowledge if the page allocator and the memory reclaim internals which
strongly suggests that a helper should be implemented in the memory
subsystem proper.
Most callers, I could find, have been converted to use the helper
instead. This is patch 5. There are some more relying on __GFP_REPEAT
in the networking stack which I have converted as well and Eric Dumazet
was not opposed [2] to convert them as well.
[1] http://lkml.kernel.org/r/20170112153717.28943-1-mhocko@kernel.org
[2] http://lkml.kernel.org/r/1485273626.16328.301.camel@edumazet-glaptop3.roam.corp.google.com
Michal Hocko (9):
mm: introduce kv[mz]alloc helpers
mm: support __GFP_REPEAT in kvmalloc_node for >32kB
rhashtable: simplify a strange allocation pattern
ila: simplify a strange allocation pattern
treewide: use kv[mz]alloc* rather than opencoded variants
net: use kvmalloc with __GFP_REPEAT rather than open coded variant
md: use kvmalloc rather than opencoded variant
bcache: use kvmalloc
net, bpf: use kvzalloc helper
arch/s390/kvm/kvm-s390.c | 10 +---
arch/x86/kvm/lapic.c | 4 +-
arch/x86/kvm/page_track.c | 4 +-
arch/x86/kvm/x86.c | 4 +-
crypto/lzo.c | 4 +-
drivers/acpi/apei/erst.c | 8 +--
drivers/char/agp/generic.c | 8 +--
drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +-
drivers/md/bcache/super.c | 8 +--
drivers/md/bcache/util.h | 12 +----
drivers/md/dm-ioctl.c | 13 ++---
drivers/md/dm-stats.c | 7 +--
drivers/net/ethernet/chelsio/cxgb3/cxgb3_defs.h | 3 --
drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 29 ++---------
drivers/net/ethernet/chelsio/cxgb3/l2t.c | 8 +--
drivers/net/ethernet/chelsio/cxgb3/l2t.h | 1 -
drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 12 ++---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 --
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 10 ++--
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 8 +--
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 31 ++----------
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 13 +++--
drivers/net/ethernet/chelsio/cxgb4/l2t.c | 2 +-
drivers/net/ethernet/chelsio/cxgb4/sched.c | 12 ++---
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 9 ++--
drivers/net/ethernet/mellanox/mlx4/mr.c | 9 ++--
drivers/nvdimm/dimm_devs.c | 5 +-
.../staging/lustre/lnet/libcfs/linux/linux-mem.c | 11 +----
drivers/vhost/net.c | 9 ++--
drivers/vhost/vhost.c | 15 ++----
drivers/vhost/vsock.c | 9 ++--
drivers/xen/evtchn.c | 14 +-----
fs/btrfs/ctree.c | 9 ++--
fs/btrfs/ioctl.c | 9 ++--
fs/btrfs/send.c | 27 ++++------
fs/ceph/file.c | 9 ++--
fs/ext4/mballoc.c | 2 +-
fs/ext4/super.c | 4 +-
fs/f2fs/f2fs.h | 20 --------
fs/f2fs/file.c | 4 +-
fs/f2fs/segment.c | 14 +++---
fs/select.c | 5 +-
fs/seq_file.c | 16 +-----
fs/xattr.c | 27 ++++------
include/linux/kvm_host.h | 2 -
include/linux/mlx5/driver.h | 7 +--
include/linux/mm.h | 22 +++++++++
include/linux/vmalloc.h | 1 +
ipc/util.c | 7 +--
kernel/bpf/syscall.c | 19 ++------
lib/iov_iter.c | 5 +-
lib/rhashtable.c | 13 ++---
mm/frame_vector.c | 5 +-
mm/nommu.c | 5 ++
mm/util.c | 57 ++++++++++++++++++++++
mm/vmalloc.c | 9 +++-
net/core/dev.c | 24 ++++-----
net/ipv4/inet_hashtables.c | 6 +--
net/ipv4/tcp_metrics.c | 5 +-
net/ipv6/ila/ila_xlat.c | 8 +--
net/mpls/af_mpls.c | 5 +-
net/netfilter/x_tables.c | 37 ++++----------
net/netfilter/xt_recent.c | 5 +-
net/sched/sch_choke.c | 5 +-
net/sched/sch_fq.c | 12 +----
net/sched/sch_fq_codel.c | 26 +++-------
net/sched/sch_hhf.c | 33 ++++---------
net/sched/sch_netem.c | 6 +--
net/sched/sch_sfq.c | 6 +--
security/apparmor/apparmorfs.c | 2 +-
security/apparmor/include/lib.h | 11 -----
security/apparmor/lib.c | 30 ------------
security/apparmor/match.c | 2 +-
security/apparmor/policy_unpack.c | 2 +-
security/keys/keyctl.c | 22 +++------
virt/kvm/kvm_main.c | 18 ++-----
76 files changed, 279 insertions(+), 583 deletions(-)
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 0/6 v3] kvmalloc Michal Hocko <mhocko@kernel.org> - 2017-01-30 11:00 +0100
[PATCH 8/9] bcache: use kvmalloc Michal Hocko <mhocko@kernel.org> - 2017-01-30 11:00 +0100
Re: [PATCH 8/9] bcache: use kvmalloc Vlastimil Babka <vbabka@suse.cz> - 2017-01-30 18:00 +0100
Re: [PATCH 8/9] bcache: use kvmalloc Michal Hocko <mhocko@kernel.org> - 2017-01-30 18:30 +0100
[PATCH 9/9] net, bpf: use kvzalloc helper Michal Hocko <mhocko@kernel.org> - 2017-01-30 11:00 +0100
Re: [PATCH 9/9] net, bpf: use kvzalloc helper Michal Hocko <mhocko@kernel.org> - 2017-01-30 18:30 +0100
[PATCH 4/9] ila: simplify a strange allocation pattern Michal Hocko <mhocko@kernel.org> - 2017-01-30 11:00 +0100
Re: [PATCH 4/9] ila: simplify a strange allocation pattern Vlastimil Babka <vbabka@suse.cz> - 2017-01-30 16:30 +0100
[PATCH 2/9] mm: support __GFP_REPEAT in kvmalloc_node for >32kB Michal Hocko <mhocko@kernel.org> - 2017-01-30 11:00 +0100
[PATCH 7/9] md: use kvmalloc rather than opencoded variant Michal Hocko <mhocko@kernel.org> - 2017-01-30 11:00 +0100
Re: [PATCH 7/9] md: use kvmalloc rather than opencoded variant Vlastimil Babka <vbabka@suse.cz> - 2017-01-30 18:00 +0100
Re: [PATCH 7/9] md: use kvmalloc rather than opencoded variant Mikulas Patocka <mpatocka@redhat.com> - 2017-02-01 18:40 +0100
Re: [PATCH 7/9] md: use kvmalloc rather than opencoded variant Michal Hocko <mhocko@kernel.org> - 2017-02-01 19:00 +0100
Re: [PATCH 5/9] treewide: use kv[mz]alloc* rather than opencoded variants Leon Romanovsky <leon@kernel.org> - 2017-01-30 11:40 +0100
Re: [PATCH 5/9] treewide: use kv[mz]alloc* rather than opencoded variants Vlastimil Babka <vbabka@suse.cz> - 2017-01-30 17:40 +0100
Re: [PATCH 5/9] treewide: use kv[mz]alloc* rather than opencoded variants Kees Cook <keescook@chromium.org> - 2017-01-30 20:30 +0100
Re: [PATCH 0/6 v3] kvmalloc Michal Hocko <mhocko@kernel.org> - 2017-02-05 11:30 +0100
csiph-web