Re: [PATCH] Mtd: nand - Fix possible NULL derefrence.

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Mtd: nand - Fix possible NULL derefrence.
Date	2017-01-30 09:10 +0100
Message-ID	<t5fce-1Ac-15@gated-at.bofh.it> (permalink)
References	<t5co1-8ip-7@gated-at.bofh.it> <t5co1-8ip-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Shailendra,

Marek and I already reviewed this patch, and you're resending it
without any of the comments addressed. Is this a mistake?

On Mon, 30 Jan 2017 10:29:17 +0530
Shailendra Verma <shailendra.v@samsung.com> wrote:

> of_match_device could return NULL, and so can cause a NULL
> pointer dereference later.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
>  drivers/mtd/nand/mxc_nand.c  |    4 ++++
>  drivers/mtd/nand/vf610_nfc.c |    4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index d7f724b..ca1b8ad 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -1596,6 +1596,10 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host)
>  	if (!np)
>  		return 1;
>  
> +	if (!of_id) {
> +		dev_err(host->dev, "Error: No device match found\n");
> +		return -ENODEV;
> +	}
>  	host->devtype_data = of_id->data;
>  
>  	return 0;
> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
> index 3ad514c..0e09c11 100644
> --- a/drivers/mtd/nand/vf610_nfc.c
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -674,6 +674,10 @@ static int vf610_nfc_probe(struct platform_device *pdev)
>  	}
>  
>  	of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev);
> +	if (!of_id) {
> +		dev_err(&pdev->dev, "Error: No device match found\n");
> +		return -ENODEV;
> +	}
>  	nfc->variant = (enum vf610_nfc_variant)of_id->data;
>  
>  	for_each_available_child_of_node(nfc->dev->of_node, child) {

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Mtd: nand - Fix possible NULL derefrence. Shailendra Verma <shailendra.v@samsung.com> - 2017-01-30 06:10 +0100
  Re: [PATCH] Mtd: nand - Fix possible NULL derefrence. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-30 09:10 +0100

csiph-web