Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1569468
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] perf evsel: Check for NULL before perf_evsel__is_bpf_output() |
| Date | 2017-01-30 10:00 +0100 |
| Message-ID | <t5fYC-1PU-5@gated-at.bofh.it> (permalink) |
| References | <t5cHo-8r7-3@gated-at.bofh.it> <t5cHn-8r7-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jan 30, 2017 at 02:23:39PM +0900, Taeung Song wrote:
> If 'evsel' is NULL, in perf_evsel__is_bpf_output()
> NULL pointer error can happen so check it.
>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> tools/perf/util/evsel.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 04e536a..b77da72 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -242,8 +242,10 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx)
> {
> struct perf_evsel *evsel = zalloc(perf_evsel__object.size);
>
> - if (evsel != NULL)
> - perf_evsel__init(evsel, attr, idx);
> + if (!evsel)
> + return NULL;
> +
> + perf_evsel__init(evsel, attr, idx);
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] perf evsel: Check for NULL before perf_evsel__is_bpf_output() Taeung Song <treeze.taeung@gmail.com> - 2017-01-30 06:30 +0100
Re: [PATCH 2/2] perf evsel: Check for NULL before perf_evsel__is_bpf_output() Jiri Olsa <jolsa@redhat.com> - 2017-01-30 10:00 +0100
Re: [PATCH 2/2] perf evsel: Check for NULL before perf_evsel__is_bpf_output() Taeung Song <treeze.taeung@gmail.com> - 2017-01-30 11:40 +0100
csiph-web