Re: [PATCH v2 1/2] nvmem: sunxi-sid: add support for H3 and A64's SID controller

From	maxime.ripard@free-electrons.com
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] nvmem: sunxi-sid: add support for H3 and A64's SID controller
Date	2017-01-30 08:50 +0100
Message-ID	<t5eSS-1eL-5@gated-at.bofh.it> (permalink)
References	<t5eSS-1eL-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, Jan 29, 2017 at 09:56:40AM +0800, Icenowy Zheng wrote:
> H3 and A64 SoCs have a bigger SID controller, which has its direct read
> address at 0x200 position in the SID block, not 0x0.
> 
> Also, H3 SID controller has some silicon bug that makes the direct read
> value wrong at first, add code to workaround the bug. (This bug has
> already been fixed on A64 and later SoCs)
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Please split that into several patches. One to allow to set the size
through the structure, one to support the A64, and one to support the
H3.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/2] nvmem: sunxi-sid: add support for H3 and A64's  SID controller maxime.ripard@free-electrons.com - 2017-01-30 08:50 +0100

csiph-web