Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1569397

[PATCH] Memory - Fix possible NULL derefrence.

From Shailendra Verma <shailendra.v@samsung.com>
Newsgroups linux.kernel
Subject [PATCH] Memory - Fix possible NULL derefrence.
Date 2017-01-30 06:20 +0100
Message-ID <t5cxI-8lg-1@gated-at.bofh.it> (permalink)
References <t5cxI-8lg-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


of_device_get_match_data could return NULL, and so can cause
a NULL pointer dereference later.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
 drivers/memory/atmel-sdramc.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/memory/atmel-sdramc.c b/drivers/memory/atmel-sdramc.c
index 12080b0..cb63fbe 100644
--- a/drivers/memory/atmel-sdramc.c
+++ b/drivers/memory/atmel-sdramc.c
@@ -57,6 +57,10 @@ static int atmel_ramc_probe(struct platform_device *pdev)
 	struct clk *clk;
 
 	caps = of_device_get_match_data(&pdev->dev);
+	if (!caps) {
+		dev_err(&pdev->dev, "no device match found\n");
+		return -ENODEV;
+	}
 
 	if (caps->has_ddrck) {
 		clk = devm_clk_get(&pdev->dev, "ddrck");
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] Memory - Fix possible NULL derefrence. Shailendra Verma <shailendra.v@samsung.com> - 2017-01-30 06:20 +0100
  Re: [PATCH] Memory - Fix possible NULL derefrence. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-01-30 09:00 +0100

csiph-web