Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569378

[PATCH V2 1/2] ACPI: processor_perflib: Simplify code and stop using CPUFREQ_START

Show all headers | View raw

acpi_processor_ppc_notifier() can live without using CPUFREQ_START
(which is gonna be removed soon), as it is only used while setting
ignore_ppc to 0. This can be done with the help of "ignore_ppc < 0"
check alone. The notifier function anyway ignores all events except
CPUFREQ_ADJUST and dropping CPUFREQ_START wouldn't harm at all.

Once CPUFREQ_START event is removed from the cpufreq core,
acpi_processor_ppc_notifier() will get called only for CPUFREQ_NOTIFY or
CPUFREQ_ADJUST event. Drop the return statement from the first if block
to make sure we don't ignore any such events.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
V1->V2:
- Improved changelog
- Don't move the first if block to a later point, as it becomes useless
  then.
---
 drivers/acpi/processor_perflib.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index f0b4a981b8d3..18b72eec3507 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -75,10 +75,8 @@ static int acpi_processor_ppc_notifier(struct notifier_block *nb,
 	struct acpi_processor *pr;
 	unsigned int ppc = 0;
 
-	if (event == CPUFREQ_START && ignore_ppc <= 0) {
+	if (ignore_ppc < 0)
 		ignore_ppc = 0;
-		return 0;
-	}
 
 	if (ignore_ppc)
 		return 0;
-- 
2.7.1.410.g6faf27b

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] ACPI: processor_perflib: Simplify code and stop using CPUFREQ_START "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-28 12:40 +0100
  [PATCH V2 1/2] ACPI: processor_perflib: Simplify code and stop using CPUFREQ_START Viresh Kumar <viresh.kumar@linaro.org> - 2017-01-30 05:40 +0100
    Re: [PATCH V2 1/2] ACPI: processor_perflib: Simplify code and stop  using CPUFREQ_START "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-30 08:20 +0100
      Re: [PATCH V2 1/2] ACPI: processor_perflib: Simplify code and stop  using CPUFREQ_START "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-30 09:00 +0100

csiph-web