Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571340

Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line

From Felipe Balbi <balbi@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line
Date 2017-02-01 10:10 +0100
Message-ID <t5Z5o-3VC-23@gated-at.bofh.it> (permalink)
References <t5SGB-8og-5@gated-at.bofh.it> <t5SGB-8og-7@gated-at.bofh.it> <t5Y9j-3lP-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Greg KH <gregkh@linuxfoundation.org> writes:
> On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote:
>> Other unsigned properties return hexadecimal values, follow this
>> convention when printing b_vendor_code too. Also add newlines to
>> the OS Descriptor support related properties, like other sysfs
>> files use.
>
> configfs is not sysfs, so watch out, you might not need/want those new
> lines as tools read the values and are not expecting them.
>
> Have you verified that nothing will break with this?  How have you
> tested it?

I would rather not change things like that, specially since Android guys
are alreadying using configfs.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Stefan Agner <stefan@agner.ch> - 2017-02-01 03:20 +0100
  [PATCH 2/2] fs: configfs: use hexadecimal values and new line Stefan Agner <stefan@agner.ch> - 2017-02-01 03:20 +0100
    Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line Greg KH <gregkh@linuxfoundation.org> - 2017-02-01 09:10 +0100
      Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line Felipe Balbi <balbi@kernel.org> - 2017-02-01 10:10 +0100
        Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line Stefan Agner <stefan@agner.ch> - 2017-02-01 18:00 +0100
  Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Greg KH <gregkh@linuxfoundation.org> - 2017-02-01 09:10 +0100
    Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Stefan Agner <stefan@agner.ch> - 2017-02-01 18:00 +0100
      Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Stefan Agner <stefan@agner.ch> - 2017-02-09 19:10 +0100
        Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Greg KH <gregkh@linuxfoundation.org> - 2017-02-10 12:40 +0100
          Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Felipe Balbi <balbi@kernel.org> - 2017-02-10 13:40 +0100
            Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Stefan Agner <stefan@agner.ch> - 2017-02-10 21:40 +0100
              Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Felipe Balbi <balbi@kernel.org> - 2017-02-13 11:50 +0100
  Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Greg KH <gregkh@linuxfoundation.org> - 2017-02-01 09:10 +0100

csiph-web