Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1571337

Re: [RFC] cpuset: Enable changing of top_cpuset's mems_allowed nodemask

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [RFC] cpuset: Enable changing of top_cpuset's mems_allowed nodemask
Date 2017-02-01 10:00 +0100
Message-ID <t5YVI-3Cf-17@gated-at.bofh.it> (permalink)
References <t5r3I-8h-5@gated-at.bofh.it> <t5HBw-1Ll-13@gated-at.bofh.it> <t5Jaj-2Mv-33@gated-at.bofh.it> <t5XGi-2WB-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed 01-02-17 13:01:24, Anshuman Khandual wrote:
[...]
> More importantly it also extends the cpuset memory restriction feature
> to the logical completion without adding any regressions for the
> existing use cases. Then why not do this ? Does it add any overhead ?

Maybe it doesn't add any overhead but it just breaks the cgroups
expectation that the root cgroup covers the full resource set. No cgroup
controller allows to set limits on the root cgroup. So all this looks
like an abuse of the interface.

I haven't read the full series yet but this particular change looks like
a nogo to me.

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() Mel Gorman <mgorman@suse.de> - 2017-01-30 21:50 +0100
  [RFC] cpuset: Enable changing of top_cpuset's mems_allowed nodemask Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-01-31 15:30 +0100
    Re: [RFC] cpuset: Enable changing of top_cpuset's mems_allowed  nodemask Mel Gorman <mgorman@suse.de> - 2017-01-31 17:10 +0100
      Re: [RFC] cpuset: Enable changing of top_cpuset's mems_allowed  nodemask Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-02-01 08:40 +0100
        Re: [RFC] cpuset: Enable changing of top_cpuset's mems_allowed  nodemask Michal Hocko <mhocko@kernel.org> - 2017-02-01 10:00 +0100
        Re: [RFC] cpuset: Enable changing of top_cpuset's mems_allowed  nodemask Mel Gorman <mgorman@suse.de> - 2017-02-01 10:20 +0100
  Re: [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() Vlastimil Babka <vbabka@suse.cz> - 2017-01-31 15:40 +0100
    Re: [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-01-31 16:40 +0100

csiph-web