Re: [PATCH] tpm: fix a sparse error in tpm-sysfs.c

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: fix a sparse error in tpm-sysfs.c
Date	2017-01-31 21:40 +0100
Message-ID	<t5NnA-5bA-21@gated-at.bofh.it> (permalink)
References	<t5NnA-5bA-23@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Jan 31, 2017 at 01:43:59PM -0500, Stefan Berger wrote:
> drivers/char/tpm/tpm-sysfs.c:161:25: warning: expression using sizeof bool
> 
> Fixes: c659af78eb7b ("tpm: Check size of response before accessing data")
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> ---
>  drivers/char/tpm/tpm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> index bff37be..6b4e7aa 100644
> --- a/drivers/char/tpm/tpm.h
> +++ b/drivers/char/tpm/tpm.h
> @@ -281,7 +281,7 @@ struct permanent_flags_t {
>  typedef union {
>  	struct	permanent_flags_t perm_flags;
>  	struct	stclear_flags_t	stclear_flags;
> -	bool	owned;
> +	__u8	owned;
>  	__be32	num_pcrs;
>  	struct	tpm_version_t	tpm_version;
>  	struct	tpm_version_1_2_t tpm_version_1_2;
> -- 
> 2.4.3

A better description would be:

  The field owned has wrong sized type. This commit fixes the
  issue.

?

/Jarkko

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tpm: fix a sparse error in tpm-sysfs.c Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-31 21:40 +0100
  Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-sysfs.c Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-01 09:10 +0100
    Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-sysfs.c Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-01 12:20 +0100
      Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-sysfs.c Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-01 13:10 +0100

csiph-web